We ran integration test after patching above PR locally and didn't encounter issue. You can proceed with merging PR.
Cheers! On Fri, Aug 28, 2015 at 10:27 AM, Kevin Ratnasekera <[email protected]> wrote: > Hi all, > As mentioned in the previous mail, I have added the null check with this > pr[1] to correct the issue. Can you please review and merge this pr[1]. > [1] https://github.com/wso2/carbon-commons/pull/146/ > Regards > Kevin > > On Thu, Aug 27, 2015 at 10:05 PM, Indika Sampath <[email protected]> wrote: > >> Hi Chanaka, >> >> Both MB and GReg has regression issue due to change made by Malaka in PR >> [1]. So it was revert in PR [2]. In MB, we create internal role when adding >> new topic and grant pub/sub permission to it and assign it to user. This >> was security fix we did on event component of svn turing support branch as >> permission related fix to topic in MB 2.2.0. We migrate these fixes from >> event component to carbon-commons after moving to Git. But then again this >> was cause problem to GReg since they don't need such restriction. Finally >> we discussed [3] and revert it to original state but made some modification >> in addTopic() method. You can find latest RegistryTopicManager class in >> [4]. Only change in PR [1] was adding "if (loggedInUser != null)" check. So >> I think we could add this check again to addTopic() method and it would >> sort out regression issue face by ESB. Sorry about inconvenience cause by >> this. >> >> [1] https://github.com/wso2/carbon-commons/pull/75/files >> [2] https://github.com/wso2/carbon-commons/pull/82/files >> [3] [MB] [G-REG] Internal role created by topic name modification >> [4] >> https://github.com/wso2/carbon-commons/blob/master/components/event/org.wso2.carbon.event.core/src/main/java/org/wso2/carbon/event/core/internal/topic/registry/RegistryTopicManager.java >> >> Cheers! >> >> On Thu, Aug 27, 2015 at 7:56 PM, Chanaka Fernando <[email protected]> >> wrote: >> >>> Hi Indika, >>> >>> We are getting an exception in the ESB 490 RC1 pack due to the commit >>> [1] done by you. With this change, you have reverted a previous fix[2] done >>> by Malaka for [3]. This is causing the same issue which Malaka was fixed. >>> Can you look into this and let us know a proper solution other than >>> reverting the fix done by Malaka? >>> >>> [1] >>> https://github.com/wso2/carbon-commons/commit/e3646925bf968616c0e55f0e34c2fe5991b1a749 >>> >>> [2] https://github.com/wso2/carbon-commons/pull/75/files >>> >>> [3] https://wso2.org/jira/browse/ESBJAVA-2506 >>> >>> -- >>> -- >>> Chanaka Fernando >>> Senior Technical Lead >>> WSO2, Inc.; http://wso2.com >>> lean.enterprise.middleware >>> >>> mobile: +94 773337238 >>> Blog : http://soatutorials.blogspot.com >>> LinkedIn:http://www.linkedin.com/pub/chanaka-fernando/19/a20/5b0 >>> Twitter:https://twitter.com/chanakaudaya >>> Wordpress:http://chanakaudaya.wordpress.com >>> >>> >>> >>> >> >> >> -- >> Indika Sampath >> Senior Software Engineer >> WSO2 Inc. >> http://wso2.com >> >> Phone: +94 716 424 744 >> Blog: http://indikasampath.blogspot.com/ >> >> > -- Indika Sampath Senior Software Engineer WSO2 Inc. http://wso2.com Phone: +94 716 424 744 Blog: http://indikasampath.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
