Hi Ruwan, Changes are still not added to this repo. If we are to add these annotations, we can add to all mojos in [1]. However, I do not think it is wise to apply these changes to existing working code. Maybe later in a major release. However, since I have almost refactored feature-gen-goal I am thinking if moving to java 5 annotations over javadoc annotations.
[1] - https://github.com/wso2/maven-tools Cheers, Dinusha On Mon, Aug 31, 2015 at 9:55 AM, Ruwan Abeykoon <[email protected]> wrote: > Hi Dinusha, > Thanks, looking good. > Would you be able to send some links to the maven-tools [1] where we would > be able to convert to use annotation. I have not seen any place to use > annotation on "p2-plugin" yet. > > [1] https://github.com/wso2/maven-tools > > Cheers, > Ruwan > > On Mon, Aug 31, 2015 at 9:44 AM, Dinusha Boteju <[email protected]> wrote: > >> Hi Ruwan, >> >> I was referring maven-plugin-annotations[1]. >> >> [1] - >> https://maven.apache.org/plugin-tools/maven-plugin-plugin/examples/using-annotations.html >> >> >> On Sun, Aug 30, 2015 at 7:25 PM, Ruwan Abeykoon <[email protected]> wrote: >> >>> Hi Dinusha, >>> +1 on moving to annotation (if any), because compiler can properly >>> verify most of the syntax than with javadocs. >>> >>> I may be wrong, but I have not seen, current "carbon-p2-plugin" has any >>> javadoc tags though. Are you referring felix-scr plugin javdocs? >>> >>> >>> Cheers, >>> Ruwan >>> >>> On Sat, Aug 29, 2015 at 1:06 PM, Dinusha Boteju <[email protected]> >>> wrote: >>> >>>> Hi devs, >>>> >>>> I am in the process of redesigning and refactoring carbon-p2-plugin. >>>> This is a module in the maven-tools project. While I was checking these >>>> plugins I noted that these mojos are written using javadoc tags. Since I am >>>> in the process of redesigning the p2 plugin I was thinking whether to use >>>> java 5 annotations for this[1]. So plugin developers, I would like to have >>>> your thoughts on this. >>>> >>>> [1] - >>>> >>>> https://maven.apache.org/plugin-tools/maven-plugin-plugin/examples/using-annotations.html >>>> <https://maven.apache.org/plugin-tools/maven-plugin-plugin/examples/using-annotations.html> >>>> [2] - >>>> https://maven.apache.org/plugin-tools/maven-plugin-tools-annotations/index.html >>>> [3] - >>>> https://maven.apache.org/components/plugin-tools/maven-plugin-tools-java/ >>>> >>>> Thanks, >>>> -- >>>> >>>> *Dinusha Boteju* >>>> *WSO2, Inc. http://wso2.com <http://wso2.com/> * >>>> *lean.enterprise.middleware.* >>>> >>>> email: [email protected] <[email protected]> >>>> phone:(+94) 776640275 <%28%2B94%29%20777739736> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> >>> *Ruwan Abeykoon* >>> *Architect,* >>> *WSO2, Inc. http://wso2.com <http://wso2.com/> * >>> *lean.enterprise.middleware.* >>> >>> email: [email protected] >>> >> >> >> >> -- >> >> *Dinusha Boteju* >> *Associate Tech Lead,* >> *WSO2, Inc. http://wso2.com <http://wso2.com/> * >> *lean.enterprise.middleware.* >> >> email: [email protected] <[email protected]> >> phone:(+94) 776640275 <%28%2B94%29%20777739736> >> > > > > -- > > *Ruwan Abeykoon* > *Architect,* > *WSO2, Inc. http://wso2.com <http://wso2.com/> * > *lean.enterprise.middleware.* > > email: [email protected] > -- *Dinusha Boteju* *Associate Tech Lead,* *WSO2, Inc. http://wso2.com <http://wso2.com/> * *lean.enterprise.middleware.* email: [email protected] <[email protected]> phone:(+94) 776640275 <%28%2B94%29%20777739736>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
