Any reason to treat the following config parameters differently, than other config parameters?
CONFIG_PARAM_CLUSTERING=false CONFIG_PARAM_DOMAIN=wso2.carbon.domain CONFIG_PARAM_WKA_MEMBERS=[127.0.0.1:4000] CONFIG_PARAM_LOCAL_MEMBER_HOST=127.0.0.1 CONFIG_PARAM_LOCAL_MEMBER_PORT=4000 CONFIG_PARAM_PORT_OFFSET=0 CONFIG_PARAM_MB_PORT=61616 CONFIG_PARAM_EMBEDDED_LDAP=true These are enabled in module.ini file by default, where as other parameters are disabled. And the default values of these config elements are removed from templates files and moved to module.ini. This is not consistent with other config parameters. Because of this, we always have to pass these parameters to configurator, even though we don't need to override the default ones. By accident, I commented out all the config parameters from module.ini and I have passed only the needed parameters to the configurator as environment variables via puppet. I ended up with some issues since I haven't pass the above parameters as environment variables (even though I don't want to override the default ones!). So isn't good if leave the default values in the template files itself? This way, we don't have explicitly pass the default values, just like other config parameters. wdyt? Thanks, Raj. On Tue, Sep 8, 2015 at 1:19 AM, Rajkumar Rajaratnam <rajkum...@wso2.com> wrote: > > > On Tue, Sep 8, 2015 at 1:16 AM, Reka Thirunavukkarasu <r...@wso2.com> > wrote: > >> Hi Raj, >> >> Yah..Seems some old reference is there in the >> master-datasources.xml.template which will not affect the configurations, >> if the parameters are defined correctly in the cartridge definition. Please >> ignore the section with CONFIG_PARAM_CONFIG_DB_APIM_URL. >> >> Please refer [1] for the sample configuration. We will clean this in the >> immediate next release(beta).. >> > > +1. Not a blocker or urgent. > > >> >> [1] >> https://github.com/wso2/product-private-paas/blob/master/samples/cartridges/ec2/wso2am-190/wso2am-190-gw-manager.json >> >> Thanks, >> Reka >> >> On Mon, Sep 7, 2015 at 6:19 PM, Rajkumar Rajaratnam <rajkum...@wso2.com> >> wrote: >> >>> Hi, >>> >>> I think API Manager's master-datasources.xml.template is messed up. For >>> example, same db username/password parameter is used for all the databases >>> and jdbc/WSO2REG_DB is defined twice with two different if-checks, why? >>> >>> Please check and fix [1]. Please check other modules also. >>> >>> [1] >>> https://github.com/wso2/product-private-paas/blob/master/cartridges/templates-modules/wso2am-1.9.0/templates/repository/conf/datasources/master-datasources.xml.template >>> >>> Thanks, >>> Raj. >>> >>> -- >>> Rajkumar Rajaratnam >>> Committer & PMC Member, Apache Stratos >>> Software Engineer, WSO2 >>> >>> Mobile : +94777568639 >>> Blog : rajkumarr.com >>> >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Reka Thirunavukkarasu >> Senior Software Engineer, >> WSO2, Inc.:http://wso2.com, >> Mobile: +94776442007 >> >> >> > > > -- > Rajkumar Rajaratnam > Committer & PMC Member, Apache Stratos > Software Engineer, WSO2 > > Mobile : +94777568639 > Blog : rajkumarr.com > -- Rajkumar Rajaratnam Committer & PMC Member, Apache Stratos Software Engineer, WSO2 Mobile : +94777568639 Blog : rajkumarr.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
