Thanks Kalpa. I've made the prescribed changes and added further comments to the PR explaining the need for dynamic imports, please check.
On 1 October 2015 at 13:25, Kalpa Welivitigoda <[email protected]> wrote: > Hi Gokul, > > Sameera and myself have put some comments in the PR. Can you please check? > > On Thu, Oct 1, 2015 at 11:44 AM, Kalpa Welivitigoda <[email protected]> > wrote: > >> Hi Gokul, >> >> I will look into this. >> >> On Thu, Oct 1, 2015 at 11:42 AM, Gokul Balakrishnan <[email protected]> >> wrote: >> >>> Hi Kernel team, >>> >>> Could you please review the PR [1] for ${subject}? >>> >>> [1] https://github.com/wso2/orbit/pull/136 >>> >>> Thanks, >>> >>> -- >>> Gokul Balakrishnan >>> Senior Software Engineer, >>> WSO2, Inc. http://wso2.com >>> Mob: +94 77 593 5789 | +1 650 272 9927 >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Best Regards, >> >> Kalpa Welivitigoda >> Software Engineer, WSO2 Inc. http://wso2.com >> Email: [email protected] >> Mobile: +94776509215 >> > > > > -- > Best Regards, > > Kalpa Welivitigoda > Software Engineer, WSO2 Inc. http://wso2.com > Email: [email protected] > Mobile: +94776509215 > -- Gokul Balakrishnan Senior Software Engineer, WSO2, Inc. http://wso2.com Mob: +94 77 593 5789 | +1 650 272 9927
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
