If the user removes the isAnonView param from the url, next time browser
will show url as
*https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=null
<https://10.100.7.19:9443/portal/dashboards/ano-db01/landing?isAnonView=null>.
*Since null value is a bit ugly I fixed it and committed it to the PR.

*Sajith Abeywardhana* | Software Engineer
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka.
Mobile: +94772260485
Email: saji...@wso2.com | Web: www.wso2.com

On Wed, Oct 7, 2015 at 10:50 AM, Udara Rathnayake <uda...@wso2.com> wrote:

> Had a chat with Sajith. Current implementation seems fine..
>
> On Wed, Oct 7, 2015 at 10:40 AM, Sajith Abeywardhana <saji...@wso2.com>
> wrote:
>
>> Hi Ayesha,
>>
>> Small clarification?
>>
>>
>>> I observed that even *anonymous users* can view the logged in view by
>>> setting query parameter "isAnonView=false" or without setting it at all in
>>> the browser.
>>>
>>
>> I think you mean in here when the *logged in user* viewing anonymous
>> view he can view logged in view by setting query parameter
>> "isAnonView=false" or without setting it at all in the browser.
>>
>> Anonymous user(with out logging) never able to view logged in view. Am I
>> right?
>>
>>
>> *Sajith Abeywardhana* | Software Engineer
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka.
>> Mobile: +94772260485
>> Email: saji...@wso2.com | Web: www.wso2.com
>>
>>
>>
>>> Can you check this.
>>>
>>> Further, instead of having this reflected in the URL can we try keep it
>>> internally?
>>>
>>> Thanks!
>>> -Ayesha
>>>
>>>
>>> On Tue, Oct 6, 2015 at 6:42 PM, Sajith Abeywardhana <saji...@wso2.com>
>>> wrote:
>>>
>>>> Both jira's[1][2] which relevant  to anon view committed under one
>>>> PR[3]. Please review and merge.
>>>>
>>>> [1]. https://wso2.org/jira/browse/UES-597
>>>> [2]. https://wso2.org/jira/browse/UES-599
>>>> [3]. https://github.com/wso2/carbon-dashboards/pull/66
>>>>
>>>> *Sajith Abeywardhana* | Software Engineer
>>>> WSO2, Inc | lean. enterprise. middleware.
>>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>>> Mobile: +94772260485
>>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>>
>>>> On Tue, Oct 6, 2015 at 2:16 PM, Sajith Abeywardhana <saji...@wso2.com>
>>>> wrote:
>>>>
>>>>> Fixed the code according to [Dev] [UES][Dashboard Server] Dashboard
>>>>> anonymous view landing page. Please merge the PR.
>>>>>
>>>>> *Sajith Abeywardhana* | Software Engineer
>>>>> WSO2, Inc | lean. enterprise. middleware.
>>>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>>>> Mobile: +94772260485
>>>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>>>
>>>>> On Tue, Oct 6, 2015 at 10:59 AM, Sajith Abeywardhana <saji...@wso2.com
>>>>> > wrote:
>>>>>
>>>>>> Please hold this merge. Page link rendering logic should be changed.
>>>>>> We can't check *!user *after the jira -
>>>>>> https://wso2.org/jira/browse/UES-597
>>>>>>
>>>>>> *Sajith Abeywardhana* | Software Engineer
>>>>>> WSO2, Inc | lean. enterprise. middleware.
>>>>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>>>>> Mobile: +94772260485
>>>>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>>>>
>>>>>> On Tue, Oct 6, 2015 at 10:38 AM, Sajith Abeywardhana <
>>>>>> saji...@wso2.com> wrote:
>>>>>>
>>>>>>> Please review and merge
>>>>>>> https://github.com/wso2/carbon-dashboards/pull/66 for
>>>>>>> https://wso2.org/jira/browse/UES-599
>>>>>>>
>>>>>>>
>>>>>>> *Sajith Abeywardhana* | Software Engineer
>>>>>>> WSO2, Inc | lean. enterprise. middleware.
>>>>>>> #20, Palm Grove, Colombo 03, Sri Lanka.
>>>>>>> Mobile: +94772260485
>>>>>>> Email: saji...@wso2.com | Web: www.wso2.com
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> *Ayesha Dissanayaka*
>>> Software Engineer,
>>> WSO2, Inc : http://wso2.com
>>> <http://www.google.com/url?q=http%3A%2F%2Fwso2.com&sa=D&sntz=1&usg=AFQjCNEZvyc0uMD1HhBaEGCBxs6e9fBObg>
>>> 20, Palmgrove Avenue, Colombo 3
>>> E-Mail: aye...@wso2.com <ayshsa...@gmail.com>
>>>
>>
>>
>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to