Hi Lahiru, I'm +1 for the above approach. But If you are proceeding with the above approach, you have to provide the workflow type in the warn message as well. On the other hand since this is a mandatory field, It is better to add detailed description about this field in appfactory.xml as a comment.
Regards, Samith On Fri, Oct 9, 2015 at 10:48 AM, Lahiru Manohara <[email protected]> wrote: > Hi All, > > In Appfactory, user can configure either default workflow (in jvm) or > external workflow (BPS server) from the appfactory.xml file within > following element. > > <!--Following configuration for workflow exentions --> > <WorkflowExetensions> > <BPS> > <Url> > https://process.appfactory.private.wso2.com:9543/services/</Url> > </BPS> > <WorkflowType name="TenantCreation"> > <Property > name="ClassName">org.wso2.carbon.appfactory.core.workflow.TenantCreationExternalWorkflowExecutor</Property> > </WorkflowType> > </WorkflowExetensions> > > But in case user forget to configure a class inside the "Property" > element, null value is getting. Current implementation this was handled by > giving a warning and assigning default workflow. > > if (StringUtils.isBlank(executorClass)) { > executorClass = WorkflowConstant.DEFAULT_WORKFLOW_CLASS; > String message = "The executor class is not define in > appfactory.xml because default workflow is " > + "executing. The default workflow class is : " + > executorClass; > log.warn(message); > } > > Is this approach confusing the user? WDYT ? > > Thanks > -- > Best regards, > > *Lahiru Manohara* > *Software Engineer* > Mobile: +94716561576 > WSO2 Inc. | http://wso2.com > lean.enterprise.middleware > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Best Regards Samith Dassanayake Software Engineer | Cloud TG WSO2, Inc. | http://wso2.com lean. enterprise. middleware Mobile : +947 76207351 Blog : buddycode.blogspot.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
