So to overcome this issue, we will follow the following approach. Create a separate module called mss-parent and move all the dependencies and plugins management to that mss-parent's pom.xml from the product-mss's root pom.xml.
Keep only the build plugins in the product-mss's root pom.xml. Refer the parent of the mss-service-parent as the newly created mss-parent. This is the same approach, we have followed in the carbon 4.4 as well [1]. After that we have to push the mss-parent's pom.xml and mss-service-parent's pom.xml to the maven central. Any thoughts/objections regarding the above approach? [1]. https://github.com/wso2/carbon-kernel/blob/master/parent/pom.xml Regards, Aruna On Fri, Nov 13, 2015 at 10:32 AM, Nirmal Fernando <[email protected]> wrote: > > > On Wed, Nov 11, 2015 at 7:01 PM, Afkham Azeez <[email protected]> wrote: > >> >> On Wed, Nov 11, 2015 at 1:46 AM, Nirmal Fernando <[email protected]> wrote: >> >>> Do sample poms need a parent at all (if everything is in the maven >>> central)? IMO they should be self contained. >>> >> >> +1 . Kernel team can you please push the released POMs to Maven central? >> >>> >>> On a related note; License year is missing >>> https://github.com/wso2/product-mss/blob/release-1.0.0-alpha/samples/helloworld/pom.xml#L3 >>> >> >> The year is not required. I think we have already discussed this >> somewhere. >> > > Oh. ok... Have we updated the code formatters? > > >> >> >>> >>> On Wed, Nov 11, 2015 at 3:07 PM, Afkham Azeez <[email protected]> wrote: >>> >>>> BTW, AS sample having a sample parent pom is wrong. Samples are there >>>> to guide the user how to write his own stuff. The user will not extend a >>>> sample parent pom from AS, so IMO it is wrong to have it in that manner in >>>> AS. >>>> >>>> On Wed, Nov 11, 2015 at 12:49 AM, Aruna Karunarathna <[email protected]> >>>> wrote: >>>> >>>>> >>>>> >>>>> On Wed, Nov 11, 2015 at 1:10 PM, Afkham Azeez <[email protected]> wrote: >>>>> >>>>>> Can we push that pom to Maven central? >>>>>> >>>>> >>>>> Will that solve the problem?. AFAIU pushing mss-service-parent pom to >>>>> maven central won't solve the problem, as per the inheritance tree we have >>>>> to push the >>>>> org.wso2.carbon.mss.parent pom to the maven central also. >>>>> >>>>> Shall we follow the pom structure as in product-as [1], having a root >>>>> pom for samples and adding the repository there, so we can pack the >>>>> samples >>>>> to the distribution? >>>>> >>>>> [1]. >>>>> https://github.com/wso2/product-as/blob/master/modules/samples/pom.xml >>>>> >>>>>> >>>>>> On Tue, Nov 10, 2015 at 11:31 PM, Aruna Karunarathna <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> >>>>>>> >>>>>>> On Wed, Nov 11, 2015 at 12:46 PM, Afkham Azeez <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> sample pom --> mss-service-parent-pom --> mss-parent-pom -> wso2-pom >>>>>>>> >>>>>>>> So, sample pom should inherit the WSO2 repo right? >>>>>>>> >>>>>>> >>>>>>> Yes. the above inheritance is correct. >>>>>>> >>>>>>> But when building the sample, AFAIU the following artifact is >>>>>>> searched in the maven central repo. So the sample pom has no idea about >>>>>>> the >>>>>>> mss-service parent? >>>>>>> >>>>>>> <parent> >>>>>>> <artifactId>mss-service-parent</artifactId> >>>>>>> <groupId>org.wso2.carbon.mss</groupId> >>>>>>> <version>1.0.0-alpha</version> >>>>>>> </parent> >>>>>>> >>>>>>> >>>>>>>> On Tue, Nov 10, 2015 at 11:13 PM, Aruna Karunarathna < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Wed, Nov 11, 2015 at 12:40 PM, Afkham Azeez <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Since we are extending from the wso2 pom, don't we automatically >>>>>>>>>> inherit the repo? >>>>>>>>>> >>>>>>>>> Yes, for the git repository it does. But the sample inside the >>>>>>>>> distribution there is no inheritance. >>>>>>>>> >>>>>>>>> >>>>>>>>>> On Tue, Nov 10, 2015 at 11:06 PM, Aruna Karunarathna < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Without building the product-mss repo, can't build the >>>>>>>>>>> helloworld sample. [1] >>>>>>>>>>> >>>>>>>>>>> After adding the wso2-nexus repo was able to build. I think we >>>>>>>>>>> need to mention in the docs for alpha release and fix this properly >>>>>>>>>>> in next >>>>>>>>>>> release. >>>>>>>>>>> >>>>>>>>>>> Following changes required to build in clean repo. >>>>>>>>>>> >>>>>>>>>>> 1. Remove the relative path in the pom.xml. >>>>>>>>>>> 2. add the wso2-nexus repository. >>>>>>>>>>> <repositories> >>>>>>>>>>> <repository> >>>>>>>>>>> <id>wso2-nexus</id> >>>>>>>>>>> <name>WSO2 internal Repository</name> >>>>>>>>>>> <url> >>>>>>>>>>> http://maven.wso2.org/nexus/content/groups/wso2-public/</url> >>>>>>>>>>> <releases> >>>>>>>>>>> <enabled>true</enabled> >>>>>>>>>>> <updatePolicy>daily</updatePolicy> >>>>>>>>>>> <checksumPolicy>ignore</checksumPolicy> >>>>>>>>>>> </releases> >>>>>>>>>>> </repository> >>>>>>>>>>> </repositories> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> [1]. >>>>>>>>>>> https://github.com/wso2/product-mss/blob/release-1.0.0-alpha/samples/helloworld/pom.xml >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> >>>>>>>>>>> *Aruna Sujith Karunarathna *| Software Engineer >>>>>>>>>>> WSO2, Inc | lean. enterprise. middleware. >>>>>>>>>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>>>>>>>>> Mobile: +94 71 9040362 | Work: +94 112145345 >>>>>>>>>>> Email: [email protected] | Web: www.wso2.com >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Afkham Azeez* >>>>>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>>>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>>>>>>> * <http://www.apache.org/>* >>>>>>>>>> *email: **[email protected]* <[email protected]> >>>>>>>>>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>>>>>>>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>>>>>>>> *twitter: **http://twitter.com/afkham_azeez* >>>>>>>>>> <http://twitter.com/afkham_azeez> >>>>>>>>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>>>>>>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>>>>>>>> >>>>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> >>>>>>>>> *Aruna Sujith Karunarathna *| Software Engineer >>>>>>>>> WSO2, Inc | lean. enterprise. middleware. >>>>>>>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>>>>>>> Mobile: +94 71 9040362 | Work: +94 112145345 >>>>>>>>> Email: [email protected] | Web: www.wso2.com >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Afkham Azeez* >>>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>>>>> * <http://www.apache.org/>* >>>>>>>> *email: **[email protected]* <[email protected]> >>>>>>>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>>>>>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>>>>>> *twitter: **http://twitter.com/afkham_azeez* >>>>>>>> <http://twitter.com/afkham_azeez> >>>>>>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>>>>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>>>>>> >>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> *Aruna Sujith Karunarathna *| Software Engineer >>>>>>> WSO2, Inc | lean. enterprise. middleware. >>>>>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>>>>> Mobile: +94 71 9040362 | Work: +94 112145345 >>>>>>> Email: [email protected] | Web: www.wso2.com >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Afkham Azeez* >>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>>> * <http://www.apache.org/>* >>>>>> *email: **[email protected]* <[email protected]> >>>>>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>>>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>>>> *twitter: **http://twitter.com/afkham_azeez* >>>>>> <http://twitter.com/afkham_azeez> >>>>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>>>> >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> *Aruna Sujith Karunarathna *| Software Engineer >>>>> WSO2, Inc | lean. enterprise. middleware. >>>>> #20, Palm Grove, Colombo 03, Sri Lanka >>>>> Mobile: +94 71 9040362 | Work: +94 112145345 >>>>> Email: [email protected] | Web: www.wso2.com >>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> *Afkham Azeez* >>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>> Member; Apache Software Foundation; http://www.apache.org/ >>>> * <http://www.apache.org/>* >>>> *email: **[email protected]* <[email protected]> >>>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>> *twitter: **http://twitter.com/afkham_azeez* >>>> <http://twitter.com/afkham_azeez> >>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>> >>>> *Lean . Enterprise . Middleware* >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> >>> Thanks & regards, >>> Nirmal >>> >>> Team Lead - WSO2 Machine Learner >>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>> Mobile: +94715779733 >>> Blog: http://nirmalfdo.blogspot.com/ >>> >>> >>> >> >> >> -- >> *Afkham Azeez* >> Director of Architecture; WSO2, Inc.; http://wso2.com >> Member; Apache Software Foundation; http://www.apache.org/ >> * <http://www.apache.org/>* >> *email: **[email protected]* <[email protected]> >> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >> *http://blog.afkham.org* <http://blog.afkham.org> >> *twitter: **http://twitter.com/afkham_azeez* >> <http://twitter.com/afkham_azeez> >> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >> <http://lk.linkedin.com/in/afkhamazeez>* >> >> *Lean . Enterprise . Middleware* >> > > > > -- > > Thanks & regards, > Nirmal > > Team Lead - WSO2 Machine Learner > Associate Technical Lead - Data Technologies Team, WSO2 Inc. > Mobile: +94715779733 > Blog: http://nirmalfdo.blogspot.com/ > > > -- *Aruna Sujith Karunarathna *| Software Engineer WSO2, Inc | lean. enterprise. middleware. #20, Palm Grove, Colombo 03, Sri Lanka Mobile: +94 71 9040362 | Work: +94 112145345 Email: [email protected] | Web: www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
