Hi Sinthuja,

I have already fixed these issues with commit [1].

These additional datasource configurations were added as commented lines in
metrics-datasources.xml and I added those just before Carbon Metrics v1.1.1
release, which is used in MB and DAS products. We found the issues only
after the release and we created a JIRA to track [2].

I'm sorry for the inconvenience. :(

Thanks for reporting these issues.

Best Regards,

[1]
https://github.com/wso2/carbon-metrics/commit/a9e66190416551d526b266c75f815add1f26cfe9
[2] https://wso2.org/jira/browse/MB-1561

On Thu, Nov 19, 2015 at 7:27 PM, Sinthuja Ragendran <sinth...@wso2.com>
wrote:

> Hi IsuruP,
>
> There are two issues we saw in the metrics-datasource configurations for
> other datasources such as MySQL, MSSQL than H2.
>
> 1) The JNDI config is mentioned as below. As there is already default
> configurations provided for the database, the jndi config also needed to be
> default. If we have the below element then the actual default name,  then
> we are using the intended advantage of having the sample datasource
> configuration already.
>
>            <jndiConfig>
>                 <name>The MySQL datasource used for WSO2 Carbon
> Metrics</name>
>             </jndiConfig>
>
> 2) defaultAutoCommit is set to false in other datasource configurations
> than H2. And I don't think this is required for the metrics datasource, and
> I don't see this config for H2 datasource as well. I believe we need to
> remove this config from the metrics datasource config.
>
> Thanks,
> Sinthuja.
> --
> *Sinthuja Rajendran*
> Associate Technical Lead
> WSO2, Inc.:http://wso2.com
>
> Blog: http://sinthu-rajan.blogspot.com/
> Mobile: +94774273955
>
>
>


-- 
Isuru Perera
Associate Technical Lead | WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

about.me/chrishantha
Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about>
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to