Hi IS team, When looking at the "org.wso2.carbon.identity.sso.saml.processors.SPInitLogoutRequestProcessor" class, I noticed that the same condition is checked twice in line 71 [1], and line 79 [2]. According to the error message in line 80 [3], checked if-condition in line 79 is incorrect.
Suggesting Fix: change the if-condition in line 79 to StringUtils.isBlank(sessionIndex) [1] https://github.com/wso2/carbon-identity/blob/master/components/sso-saml/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/processors/SPInitLogoutRequestProcessor.java#L71 [2] https://github.com/wso2/carbon-identity/blob/master/components/sso-saml/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/processors/SPInitLogoutRequestProcessor.java#L79 [3] https://github.com/wso2/carbon-identity/blob/master/components/sso-saml/org.wso2.carbon.identity.sso.saml/src/main/java/org/wso2/carbon/identity/sso/saml/processors/SPInitLogoutRequestProcessor.java#L80 Thanks. -- Sajith Ariyarathna Software Engineer; WSO2, Inc.; http://wso2.com/ mobile: +94 77 6602284, +94 71 3951048
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
