Hi Malmee and Nishadi, Good progress in a short time!
Had a glance at the code, couple of things I noticed: 1. log4j.properties file is available under conf directory as well as the resources directory. Ideally should be in conf directory. 2. In the class OldArtifactLoader [1], the methods are throwing IOException in an error scenario. A better approach would be to wrap that with a custom exception (ex.: ArtifactLoadingException, etc.) and throw it. WDYT? In the class Transformation [2], this approach is followed. [1]. https://github.com/nishadi/product-private-paas/blob/master/tools/migration/ppaas-artifact-converter/src/main/java/org/wso2/ppaas/tools/artifactmigration/loader/OldArtifactLoader.java [2]. https://github.com/nishadi/product-private-paas/blob/master/tools/migration/ppaas-artifact-converter/src/main/java/org/wso2/ppaas/tools/artifactmigration/Transformation.java On Sat, Dec 5, 2015 at 10:25 PM, Gayan Gunarathne <[email protected]> wrote: > Great stuff. This is a really important tool in the case of Private PaaS > migration. > > As per the README[1] it mention as "Add the default values to the > templates folder, if needed".I am not clear on that? Are we packing the > 4.1.0 artifacts templates with the artifact migration tool? So user need to > put the default values for those artifacts? > > [1] > https://github.com/nishadi/product-private-paas/blob/master/tools/migration/ppaas-artifact-converter/README > > Thanks, > Gayan > > On Fri, Dec 4, 2015 at 2:51 PM, Nishadi Kirielle <[email protected]> wrote: > >> Hi All, >> >> Currently,we are engaged in developing an artifact migration tool to be >> used to fetch the artifact json files from PPaaS 4.0.0 REST API endpoints >> and convert them to be compatible with PPaaS 4.1.0. [1] >> >> We have implemented the conversions for the following artifacts ; >> - auto scale policy artifacts >> - network partition list artifacts >> - deployment policy artifacts >> - cartridge artifacts >> >> Now we are implementing the conversion of cartridge subscription >> artifacts to application signups and domain mapping subscriptions. >> >> Please raise if there are any concerns regarding this work. >> >> [1] >> https://github.com/nishadi/product-private-paas/tree/master/tools/migration/ppaas-artifact-converter >> >> Thanks >> Nishadi >> >> -- >> Nishadi Kirielle >> *Software Engineering Intern* >> Mobile : +94 (0) 714722148 >> [email protected] >> >> _______________________________________________ >> Dev mailing list >> [email protected] >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > Gayan Gunarathne > Technical Lead, WSO2 Inc. (http://wso2.com) > Committer & PMC Member, Apache Stratos > email : [email protected] | mobile : +94 775030545 <%2B94%20766819985> > > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Thanks and Regards, Isuru H. +94 716 358 048* <http://wso2.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
