Thanks a lot Frank for taking your time to review a 45pg doc. :) I've replied to few of your comments.
Unfortunately, I've got an event to attend this Wednesday. Currently, I have Monday and Tuesday free on my calendar. Please let me know if one of those days works for you. On Sun, Dec 13, 2015 at 4:52 PM, Frank Leymann <[email protected]> wrote: > Dear Thamali, > > I added a bunch of comments. For each of the methods (get, post,....) I > suggested modifications to your API that you may want to use as template > for the other APIs; of course, I argued why I suggested individual pieces. > I also started to make use of Swagger Paramters: and Definitions: sections > to better ensure reuse of the different declarations of the API. > > Finally: I need to much better understand the ML data model. See my > comments for clarification need I have :-) This understanding is key to be > able to recommend the use of "processing function resources" or not. > > I am looking forward to our discussion on Wednesday... > > > Best regards, > Frank > > 2015-12-01 12:55 GMT+01:00 Thamali Wijewardhana <[email protected]>: > >> Link for the swagger definition: >> >> >> https://docs.google.com/a/wso2.com/document/d/1KYmXyuEFJMhFMy6p-SjRztVrgW8mr83LZR2U4BK4d-M/edit?usp=sharing >> >> >> On Tue, Dec 1, 2015 at 4:32 PM, Thamali Wijewardhana <[email protected]> >> wrote: >> >>> >>> >>> On Thu, Nov 26, 2015 at 7:40 PM, Frank Leymann <[email protected]> wrote: >>> >>>> Dear all, sorry for the delay :-( >>>> >>>> What about one of the following time slots: >>>> >>>> Tuesday, Dec 1, 4pm Colombo Time >>>> Wednesday, Dec 2, 4pm Colombo Time >>>> Friday, Dec 4, 4pm Colombo Time >>>> >>>> I will be available later than 4pm but this won't be convenient for you >>>> in Colombo. >>>> >>>> >>>> >>>> Best regards, >>>> Frank >>>> >>>> 2015-11-25 8:43 GMT+01:00 Nirmal Fernando <[email protected]>: >>>> >>>>> Hi Frank, >>>>> >>>>> Could you please let us know few time slots? >>>>> >>>>> On Mon, Nov 23, 2015 at 9:29 AM, Nirmal Fernando <[email protected]> >>>>> wrote: >>>>> >>>>>> Absolutely. We'll wait till Frank confirms a time. Thanks. >>>>>> >>>>>> On Sun, Nov 22, 2015 at 10:18 PM, Sanjeewa Malalgoda < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Hi nirmal, >>>>>>> please invite apim rest api team as well. we would like to join this >>>>>>> discussion. >>>>>>> >>>>>>> Thanks >>>>>>> sanjeewa. >>>>>>> >>>>>>> sent from my phone >>>>>>> On Nov 22, 2015 7:00 PM, "Nirmal Fernando" <[email protected]> wrote: >>>>>>> >>>>>>>> Thanks Frank for the response. +1 for having a call. Could you >>>>>>>> please propose few time slots? >>>>>>>> >>>>>>>> On Sun, Nov 22, 2015 at 6:55 PM, Frank Leymann <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Dear Thamali, >>>>>>>>> >>>>>>>>> we (APIM, ES Publisher,... teams) developed some guidelines on >>>>>>>>> making all of our APIs more consistent. For example, versioning >>>>>>>>> (major, >>>>>>>>> minor, patch) as part of the URL context etc. Also, you are not >>>>>>>>> using PUT >>>>>>>>> but always POST - this has some implications a bunch of REST-folks are >>>>>>>>> serious about. Similarly, the use of proper HTTP headers is a REST >>>>>>>>> issue to >>>>>>>>> reduce the amount of data transferred, to avoid potential concurrency >>>>>>>>> problems etc. >>>>>>>>> >>>>>>>>> Should we have a call to discuss the API and check where we can >>>>>>>>> help? >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> Best regards, >>>>>>>>> Frank >>>>>>>>> >>>>>>>>> 2015-11-18 12:10 GMT+01:00 Nirmal Fernando <[email protected]>: >>>>>>>>> >>>>>>>>>> Thanks Thamali! Please try to generate the Swagger definition for >>>>>>>>>> ML API as the next step. >>>>>>>>>> >>>>>>>>>> On Wed, Nov 18, 2015 at 12:21 PM, Thamali Wijewardhana < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> REST API standards define the way to produce a RESTful API. For >>>>>>>>>>> an API to become a RESTful API, it should confirm to those REST >>>>>>>>>>> standards.This document includes a set of improvements to make the >>>>>>>>>>> WSO2 >>>>>>>>>>> API, a RESTful API. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> https://docs.google.com/spreadsheets/d/1HYiS-TpqYaZTtBLLSIeYZ_nvZkbt7zAFwetnHLe4vg8/edit#gid=0 >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> >>>>>>>>>> Thanks & regards, >>>>>>>>>> Nirmal >>>>>>>>>> >>>>>>>>>> Team Lead - WSO2 Machine Learner >>>>>>>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>>>>>>> Mobile: +94715779733 >>>>>>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> >>>>>>>> Thanks & regards, >>>>>>>> Nirmal >>>>>>>> >>>>>>>> Team Lead - WSO2 Machine Learner >>>>>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>>>>> Mobile: +94715779733 >>>>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>>>> >>>>>>>> >>>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & regards, >>>>>> Nirmal >>>>>> >>>>>> Team Lead - WSO2 Machine Learner >>>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>>> Mobile: +94715779733 >>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Thanks & regards, >>>>> Nirmal >>>>> >>>>> Team Lead - WSO2 Machine Learner >>>>> Associate Technical Lead - Data Technologies Team, WSO2 Inc. >>>>> Mobile: +94715779733 >>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>> >>>>> >>>>> >>>> >>> >> > -- Thanks & regards, Nirmal Team Lead - WSO2 Machine Learner Associate Technical Lead - Data Technologies Team, WSO2 Inc. Mobile: +94715779733 Blog: http://nirmalfdo.blogspot.com/
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
