On Fri, Jan 8, 2016 at 7:42 AM, Rajkumar Rajaratnam <[email protected]> wrote:
> > > On Fri, Jan 8, 2016 at 1:25 AM, Sajith Kariyawasam <[email protected]> > wrote: > >> Hi Raj, >> >> On Thu, Jan 7, 2016 at 5:40 PM, Rajkumar Rajaratnam <[email protected]> >> wrote: >> >>> >>> >>> On Thu, Jan 7, 2016 at 2:31 PM, Chamila De Alwis <[email protected]> >>> wrote: >>> >>>> Hi devs, >>>> >>>> In the Hiera files, the default.yaml is supposed to contain values for >>>> a "default" setup, representing a server running out of the box from a >>>> downloaded product. Therefore, the wso2::master_datasources should point to >>>> the H2 database. >>>> >>> >>> I guess we are confusing with wordings here. >>> >>> default.yaml contains configurations of a product's "default" profile in >>> a deployment. Similarly manager.yaml is for "manager" profile and so on. A >>> user can update default.yaml according to their deployment. For example, he >>> can point carbon db to an external MySQL server. >>> >>> I guess you are referring that the gov/config db configurations are >>> added in some default.yaml and they are pointed to MySQL db. This is >>> correct, we don't need to point them to H2. What we should do is, we need >>> to comment these configurations and ship the hiera yaml files. Because >>> these are not default configurations. >>> >> >> Shouldn't we move wso2_config_db, wso2_gov_db, wso2user_db blocks (which >> are under wso2::master_datasources), out of default.yaml because those too >> are not "default" configurations, and move those into worker.yaml and >> manager.yaml. >> > > These databases are not going to change across product profiles. That is > why we added them in default.yaml. If they change across profiles, then we > need to add/override them in profile specific yaml files, which is the next > hierarchy. > > In a deployment, > - wso2 platform specific configurations will be added to wso2/common.yaml > - wso2 product specific configurations will be added to default.yaml > - wso2 product profile specific configurations will be added to > <profile>.yaml > - any edge case configurations will be added to <client_cert>.yaml > This hierarchy reduces data duplication significantly. Of course, we can move config/gov db configurations to profile specific yaml files, nothing is going to break, but we are duplicating the same data in several yaml files. Thanks, Raj. > > Thanks, > Raj. > > > >> Shouldn't default.yaml profile equal to the exact same configurations of >> a fresh pack (with changing values only)? >> If that's the case why those config_db, gov_db etc defined in >> default.yaml ? >> >> >>> If a user wants, he can uncomment and modify the settings. For example, >>> refer [1]. >>> >>> [1] >>> https://github.com/wso2/puppet-modules/blob/master/hiera/hieradata/dev/wso2/wso2am/1.9.1/default.yaml#L11-L33 >>> >>> Thanks, >>> Raj. >>> >>> >>>> However, the default.yaml contains datasources pointing to a MySQL >>>> server. IMO this should change to point to the H2 database. WDYT? >>>> >>>> Regards, >>>> Chamila de Alwis >>>> Committer and PMC Member - Apache Stratos >>>> Software Engineer | WSO2 | +94772207163 >>>> Blog: code.chamiladealwis.com >>>> >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Rajkumar Rajaratnam >>> Committer & PMC Member, Apache Stratos >>> Software Engineer, WSO2 >>> >>> Mobile : +94777568639 >>> Blog : rajkumarr.com >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Sajith Kariyawasam >> *Committer and PMC member, Apache Stratos, * >> *WSO2 Inc.; http://wso2.com <http://wso2.com>* >> *Mobile: 0772269575* >> > > > > -- > Rajkumar Rajaratnam > Committer & PMC Member, Apache Stratos > Software Engineer, WSO2 > > Mobile : +94777568639 > Blog : rajkumarr.com > -- Rajkumar Rajaratnam Committer & PMC Member, Apache Stratos Software Engineer, WSO2 Mobile : +94777568639 Blog : rajkumarr.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
