Hi Akalanka, On Fri, Feb 12, 2016 at 11:37 AM, Akalanka Pagoda Arachchi < [email protected]> wrote:
> Hi Niranjan, > > Yes, we could have avoided adding h2-database-engine as a dependency in > 4.4.x Andes. > > If we add the h2 driver to the datasource feature, it would mean whenever > datasource feature is used h2 driver will be copied. Will that be OK? My > opinion is if the H2 driver is not a dependency for the feature, it should > not be contained in the feature. When we create a distribution from that > feature, if H2 DB is used as the default DB configuration, we should > provide the H2 driver with the distribution. > Sorry about it. I was under the impression that the datasource core for C5 supports by default is for H2 DB like in C4. This is why I suggested that we define it at the datasource core feature. > WDYT? > > Thanks, > Akalanka. > > On Fri, Feb 12, 2016 at 11:05 AM, Niranjan Karunanandham < > [email protected]> wrote: > >> Hi Akalanka / all >> >> On Fri, Feb 12, 2016 at 10:46 AM, Akalanka Pagoda Arachchi < >> [email protected]> wrote: >> >>> Hi All, >>> >>> In the previous distributions, we had H2 database driver as a dependency >>> for our features so that it will be copied to the plugins folder when the >>> pack is created.However, in this scenario, H2 database driver is not >>> exactly a dependency of the Andes Core feature since it is not using the H2 >>> driver. >>> >> Are you referring to the h2-database-engine jar? This was there in the >> plugins folder of kernel core zip in 4.4.x. If so, then why is andes core >> feature also packing this? >> >> >>> Therefore, my suggestion is to avoid adding H2 database driver as a >>> dependency for the Andes Core feature, but rather add it as a dependency >>> for product distribution module so that when the distribution pack is >>> created, the H2 driver, which is required for default database >>> configurations is copied to the plugins folder. >>> >>> This will be useful in reducing the Andes Core feature bundle size as >>> well. >>> >>> If any product is to install Andes Core feature, they will have to copy >>> the relevant jar file to the dropins folder if they don't already have it. >>> >>> WDYT? >>> >>> If we're to go ahead with this approach we need a way to install osgi >>> bundles to the distribution that are not available in the features or >>> create a new feature containing H2 database driver. >>> >> If we require a default DB, then I would suggest to have it with database >> core feature. WDYT? >> >> >>> >>> Please provide your thoughts. >>> >>> Thanks, >>> Akalanka. >>> >>> -- >>> *Darshana Akalanka Pagoda Arachchi,* >>> *Software Engineer* >>> *078-4721791* >>> >> >> Regards, >> Nira >> >> -- >> >> *Niranjan Karunanandham* >> Senior Software Engineer - WSO2 Inc. >> WSO2 Inc.: http://www.wso2.com >> > > > > -- > *Darshana Akalanka Pagoda Arachchi,* > *Software Engineer* > *078-4721791* > Regards, Nira -- *Niranjan Karunanandham* Senior Software Engineer - WSO2 Inc. WSO2 Inc.: http://www.wso2.com
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
