Hi Vishanth, Few comments:
- Move the property kubernetes.artifacts.version to root pom - No need to define profiles, common plugins (assembly) and repositories in each pom, they can be declared in the root pom and inherited. On Tue, Mar 1, 2016 at 9:29 AM, Vishanth Balasubramaniam <[email protected] > wrote: > Thanks Imesh. > > On Tue, Mar 1, 2016 at 7:27 AM, Imesh Gunaratne <[email protected]> wrote: > >> >> On Tue, Mar 1, 2016 at 7:16 AM, Imesh Gunaratne <[email protected]> wrote: >> >>> >>> WSO2 has repeated in the artifact names, see above >>> Might be better to rename wso2am-docker-1.0.0.zip >>> to wso2am-dockerfile-1.0.0.zip >>> >>> I have now fixed above: >> >> >> https://github.com/wso2/kubernetes-artifacts/commit/764c50282ab3f538f7bfa39e56eb25287a55d221 >> >> https://github.com/wso2/kubernetes-artifacts/commit/a3114e6b79c67bf23257ad2c61cf33375a4116ff >> >> Thanks >> >> >>> Thanks >>> >>> On Mon, Feb 29, 2016 at 1:15 PM, Chamila De Alwis <[email protected]> >>> wrote: >>> >>>> Hi Vishanth, >>>> >>>> The plan is to have the base image in Docker Public registry so that >>>> anyone can pull it whenever they want. However, IMO we should also ship the >>>> common image artifacts, in case the users need to modify the Base image. >>>> >>>> We can additionally link the common Dockerfile with the Docker registry >>>> [1]. >>>> >>>> [1] - https://docs.docker.com/docker-hub/github/ >>>> >>>> >>>> Regards, >>>> Chamila de Alwis >>>> Committer and PMC Member - Apache Stratos >>>> Software Engineer | WSO2 | +94772207163 >>>> Blog: code.chamiladealwis.com >>>> >>>> >>>> >>>> On Mon, Feb 29, 2016 at 12:41 PM, Vishanth Balasubramaniam < >>>> [email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> This is to discuss the packaging structure of Kubernetes Artifacts. >>>>> The project structure is attached [1]. The plan is to package the Docker >>>>> related distributions and Kubernetes related distributions separately per >>>>> product. >>>>> >>>>> Docker related distribution of a product would look like this. >>>>> <WSO2_PRODUCT>-Docker-1.0.0.zip >>>>> |--- <WSO2_PRODUCT>/docker >>>>> |--- Common >>>>> |------- docker/base-image >>>>> |------- scripts/docker >>>>> |--- ReadMe.md >>>>> >>>>> Should we package the docker base-image within every docker >>>>> distribution of a product or should it be packaged separately. Thoughts? >>>>> >>>>> Kubernetes related distribution of a product would look like this. >>>>> <WSO2_PRODUCT>-Kubernetes-1.0.0.zip >>>>> |--- <WSO2_PRODUCT>/kubernetes >>>>> |--- Common >>>>> |------- scripts/kubernetes >>>>> |--- ReadMe.md >>>>> >>>>> [1] - Attachment: Kubernetes-Artifacts-Project-Structure.png >>>>> >>>>> Regards, >>>>> Vishanth >>>>> >>>>> -- >>>>> *Vishanth Balasubramaniam* >>>>> Committer & PMC Member, Apache Stratos, >>>>> Software Engineer, WSO2 Inc.; http://wso2.com >>>>> >>>>> mobile: *+94 77 17 377 18* >>>>> about me: *http://about.me/vishanth <http://about.me/vishanth>* >>>>> >>>> >>>> >>> >>> >>> -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.io >>> Lean . Enterprise . Middleware >>> >>> >> >> >> -- >> *Imesh Gunaratne* >> Senior Technical Lead >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 >> W: http://imesh.io >> Lean . Enterprise . Middleware >> >> > > > -- > *Vishanth Balasubramaniam* > Committer & PMC Member, Apache Stratos, > Software Engineer, WSO2 Inc.; http://wso2.com > > mobile: *+94 77 17 377 18* > about me: *http://about.me/vishanth <http://about.me/vishanth>* > -- Thanks and Regards, Isuru H. +94 716 358 048* <http://wso2.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
