Thanks Chamila! On Tue, Mar 15, 2016 at 7:39 AM, Chamila De Alwis <[email protected]> wrote:
> This change is now in the remote with commit [1]. > > [1] - > https://github.com/wso2/dockerfiles/commit/e6465a9d93103020316cbfac908bbb41fe2ac776 > > > > Regards, > Chamila de Alwis > Committer and PMC Member - Apache Stratos > Software Engineer | WSO2 | +94772207163 > Blog: code.chamiladealwis.com > > > > On Tue, Mar 15, 2016 at 7:27 AM, Chamila De Alwis <[email protected]> > wrote: > >> Hi Vishanth, Imesh, >> >> This was introduced to keep the output of the build script to the minimum >> and to exit with a proper code if the docker build command fails. If the >> puppet run fails, the docker build command does not fail, as it does not >> seem to exit with a non-zero code. Therefore, it was necessary to grep for >> any "error" outputs and exit accordingly. >> >> However I see your point about being verbose when it comes to the build. >> I'm testing a -q flag for the build script which if used, will suppress the >> output and only show any errors. I will push the changes soon. >> >> >> >> Regards, >> Chamila de Alwis >> Committer and PMC Member - Apache Stratos >> Software Engineer | WSO2 | +94772207163 >> Blog: code.chamiladealwis.com >> >> >> >> On Mon, Mar 14, 2016 at 5:11 PM, Imesh Gunaratne <[email protected]> wrote: >> >>> IMO it is important to show the docker build command output to the user. >>> Otherwise it would be difficult for the user to understand what's happening >>> behind the scene. >>> >>> Thanks >>> >>> On Mon, Mar 14, 2016 at 4:07 PM, Vishanth Balasubramaniam < >>> [email protected]> wrote: >>> >>>> Hi, >>>> >>>> Currently when building the wso2 docker images [1], we are not >>>> prompting the complete image building logs [2], we are only prompting if >>>> there is any error while building. >>>> >>>> Is there any specific reason for not prompting the complete log trace >>>> when building these images? >>>> >>>> Isn't it better to show the complete build logs or at least an option >>>> for user to see the complete logs? Thoughts? >>>> >>>> [1] - https://github.com/wso2/dockerfiles >>>> [2] - >>>> https://github.com/wso2/dockerfiles/blob/master/common/scripts/docker-build.sh#L196-L208 >>>> >>>> Regards, >>>> Vishanth >>>> -- >>>> *Vishanth Balasubramaniam* >>>> Committer & PMC Member, Apache Stratos, >>>> Software Engineer, WSO2 Inc.; http://wso2.com >>>> >>>> mobile: *+94 77 17 377 18* >>>> about me: *http://about.me/vishanth <http://about.me/vishanth>* >>>> >>> >>> >>> >>> -- >>> *Imesh Gunaratne* >>> Senior Technical Lead >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: http://imesh.io >>> Lean . Enterprise . Middleware >>> >>> >> > -- *Imesh Gunaratne* Senior Technical Lead WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: http://imesh.io Lean . Enterprise . Middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
