On Tue, Apr 5, 2016 at 3:32 PM, Niranjan Karunanandham <[email protected]> wrote:
> Hi Kishanthan, > > On Tue, Apr 5, 2016 at 3:23 PM, Kishanthan Thangarajah < > [email protected]> wrote: > >> +1 >> >> Also by default, we need to have place holders for name, id and version >> properties rather than having hard coded values. The product team can then >> put their relevant values at build time. Let's add this also along with >> this change. >> > By default shall we have the above values as empty in the carbon.yml. If > it is not defined pick it up from System properties (using the place holder > carbon.name, carbon.id and carbon.version for name, id and version > respectively). If both are not define then get the values from a Constant. > WDYT? > IMO, let's have it like this. id: ${server.key} name: ${server.name} version: ${server.version} If no value is set for this under system property or env property, we should use the default values which comes from the configuration bean. The product team can use their own values when building a product. > >> >> >> On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna <[email protected]> >> wrote: >> >>> On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham < >>> [email protected]> wrote: >>> >>>> Hi Devs, >>>> >>>> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the >>>> distribution folder and copied to the distribution pack via bin.xml. Why >>>> don't we add these configuration files to Carbon Server Feature >>>> (org.wso2.carbon.core.server.feature) which are copied to the packed when >>>> the feature is installed. WDYT? >>>> >>>> +1. we should bring the configurations also when we install the core >>> feature. >>> >>> Regards, >>>> Nira >>>> >>>> -- >>>> >>>> *Niranjan Karunanandham* >>>> Senior Software Engineer - WSO2 Inc. >>>> WSO2 Inc.: http://www.wso2.com >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> >>> *Aruna Sujith Karunarathna * >>> WSO2, Inc | lean. enterprise. middleware. >>> #20, Palm Grove, Colombo 03, Sri Lanka >>> Mobile: +94 71 9040362 | Work: +94 112145345 >>> Email: [email protected] | Web: www.wso2.com >>> >>> >> >> >> >> -- >> *Kishanthan Thangarajah* >> Associate Technical Lead, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > > Regards, > Nira > > -- > > *Niranjan Karunanandham* > Senior Software Engineer - WSO2 Inc. > WSO2 Inc.: http://www.wso2.com > -- *Kishanthan Thangarajah* Associate Technical Lead, Platform Technologies Team, WSO2, Inc. lean.enterprise.middleware Mobile - +94773426635 Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
