Hi Sajith, Here .../apps/application/... part seems redundant. I like to propose " http://localhost:9763/api/appm/publisher/v1.0/apps/binaries";.
+1 On Thu, Apr 7, 2016 at 12:57 PM, SajithAR Ariyarathna <[email protected]> wrote: > Hi Ruwan, > > Images can be quite big right.. > 1MB (if we haven't prescribed a limit >> e.g. < 400kb) wouldn't thilini's approach be better? > > That is actually a valid point. So +1 for an image upload API. > > 2. Implementing a dedicated API for image upload only. In this case, we >> can implement this API in order to be reused in webapp image upload also. >> > +1 > > Thanks. > > On Thu, Apr 7, 2016 at 12:34 PM, Ruwan Yatawara <[email protected]> wrote: > >> Hi Sajith, >> >> Images can be quite big right.. > 1MB (if we haven't prescribed a limit >> e.g. < 400kb) wouldn't thilini's approach be better? >> >> Thanks and Regards, >> >> Ruwan Yatawara >> >> Senior Software Engineer, >> WSO2 Inc. >> >> email : [email protected] >> mobile : +94 77 9110413 >> blog : http://ruwansrants.blogspot.com/ >> www: :http://wso2.com >> >> >> On Thu, Apr 7, 2016 at 12:23 PM, SajithAR Ariyarathna <[email protected]> >> wrote: >> >>> Hi Thilini, >>> >>> ... in order to create a mobile app, we have to initially upload >>>> relevant application binary and image files of app thumbnail, banner and >>>> screenshots ... >>>> >>> What is the reason behind this? As I remember in the current AppM, both >>> text data (app name, version , description etc.) and images (banner, >>> screenshots) are submitted via a single POST request when creating a new >>> app. Why we are separating image upload? >>> >>> Our suggestion here is to rename the API as >>>> http://localhost:9763/api/appm/publisher/v1.0/apps/application/ >>>> <http://localhost:9763/publisher/api/mobileapp/upload>binaries and >>>> making the API more generic. >>> >>> Here .../apps/application/... part seems redundant. I like to propose " >>> http://localhost:9763/api/appm/publisher/v1.0/apps/binaries";. >>> >>> Thanks. >>> >>> On Thu, Apr 7, 2016 at 11:44 AM, Thilini Shanika <[email protected]> >>> wrote: >>> >>>> Hi all, >>>> >>>> We have a concern regarding the design of mobile application >>>> binary/image upload API. As per the discussions we had on the new design of >>>> the API model, we decided to use a separate API to upload mobile binary >>>> files(.apk, .ipa) including the images. Thus, in order to create a mobile >>>> app, we have to initially upload relevant application binary and image >>>> files of app thumbnail, banner and screenshots and later the application >>>> should be created with the references to uploaded binaries. >>>> We have already implemented the REST API for application binary upload. >>>> But we have few concerns regarding the image file upload. We have two >>>> options in implementing image upload scenario. >>>> >>>> >>>> 1. Reusing the binary upload API for image upload also. But in this >>>> case, we need to change the API design in order to distinguish the >>>> uploading file type (Whether is it is an app binary or an image for >>>> screenshots, thumbnails etc) since we have separate flows of processing >>>> the >>>> files. >>>> 2. Implementing a dedicated API for image upload only. In this >>>> case, we can implement this API in order to be reused in webapp image >>>> upload also. >>>> >>>> >>>> As per the offline discussion I had with RuwanA, another concern was >>>> raised regarding the URL for binary upload API. The current URL is ' >>>> http://localhost:9763/api/appm/publisher/v1.0/apps/mobile/ >>>> <http://localhost:9763/publisher/api/mobileapp/upload>binaries'. But >>>> this particular URL is mobile application specific. In that case, we cannot >>>> reuse this API in future, for any other application binary upload, other >>>> that mobile binary upload. Our suggestion here is to rename the API as >>>> http://localhost:9763/api/appm/publisher/v1.0/apps/application/ >>>> <http://localhost:9763/publisher/api/mobileapp/upload>binaries and >>>> making the API more generic. >>>> >>>> Your suggestions are highly appreciated. >>>> >>>> [1] - >>>> https://docs.google.com/document/d/1UE7SgZGsGnOgo6CokXClc6LVtI3N0tcGeXClFOT7jIA/edit >>>> >>>> >>>> Thanks, >>>> Thilini >>>> >>>> -- >>>> Thilini Shanika >>>> Software Engineer >>>> WSO2, Inc.; http://wso2.com >>>> 20, Palmgrove Avenue, Colombo 3 >>>> >>>> E-mail: [email protected] >>>> >>>> >>> >>> >>> -- >>> Sajith Janaprasad Ariyarathna >>> Software Engineer; WSO2, Inc.; http://wso2.com/ >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> > > > -- > Sajith Janaprasad Ariyarathna > Software Engineer; WSO2, Inc.; http://wso2.com/ > -- Thilini Shanika Software Engineer WSO2, Inc.; http://wso2.com 20, Palmgrove Avenue, Colombo 3 E-mail: [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
