Thank you Willian. Great if you could create a pull request for [1] @Rajjaz - Can we check this improvement and add to our code base on Monday?
[1] https://github.com/wso2-extensions/esb-connector-ldap On Fri, May 6, 2016 at 11:29 PM, Willian Antunes < [email protected]> wrote: > It's done. > > Sorry for the missing headers. I edited the files from Developer Studio, > it erases the XML file to a new one every time you open it. So even when a > comment is inserted, the file will be erased again in the design view. > > Thanks! > > On Fri, May 6, 2016 at 2:16 PM, Malaka Silva <[email protected]> wrote: > >> Hi Willian, >> >> Thank you for the fix and your contribution. >> >> I went through the fix. Added few comments. >> >> Please send the pr. We will review again and merge. Fix will be available >> via store afterwards. >> >> >> >> On Fri, May 6, 2016 at 5:19 PM, Willian Antunes < >> [email protected]> wrote: >> >>> Guys, >>> >>> I implemented a solution >>> <https://github.com/willianantunes/esb-connector-ldap/commit/0c0e5f920afa846fe2b45a97f0be9b0e2af983ad> >>> for this issue. >>> >>> The details can be found here: >>> https://wso2.org/jira/browse/ESBCONNECT-92?focusedCommentId=119727&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-119727 >>> >>> Can I submit a pull request? >>> >>> On Thu, Apr 28, 2016 at 12:39 PM, Willian Antunes < >>> [email protected]> wrote: >>> >>>> It's created: https://wso2.org/jira/browse/ESBCONNECT-92 >>>> >>>> Thank you! >>>> >>>> On Thu, Apr 28, 2016 at 12:52 AM, Malaka Silva <[email protected]> wrote: >>>> >>>>> Hi Willian, >>>>> >>>>> Please report the issue in [1]. Our team will follow it. >>>>> >>>>> [1] https://wso2.org/jira/browse/ESBCONNECT >>>>> >>>>> On Thu, Apr 28, 2016 at 12:44 AM, Willian Antunes < >>>>> [email protected]> wrote: >>>>> >>>>>> Hello community, >>>>>> >>>>>> I can connect smoothly using port 389 through LDAP Connector. There >>>>>> is no restrictions in a scenario where my route engine uses a non-secure >>>>>> port, but as far as I can see the component does not support SSL >>>>>> connection >>>>>> (as informed in the links below). Is it true? >>>>>> >>>>>> - Component GitHub project >>>>>> <https://github.com/wso2-extensions/esb-connector-ldap> >>>>>> - LDAP in WSO2 Store >>>>>> >>>>>> <https://docs.wso2.com/display/ESBCONNECTORS/Creating+a+Third+Party+Connector+and+Publishing+in+WSO2+Connector+Store> >>>>>> >>>>>> If so do I need to open an issue in GitHub? >>>>>> >>>>>> Thank you! >>>>>> >>>>>> _______________________________________________ >>>>>> Dev mailing list >>>>>> [email protected] >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> >>>>> Best Regards, >>>>> >>>>> Malaka Silva >>>>> Senior Tech Lead >>>>> M: +94 777 219 791 >>>>> Tel : 94 11 214 5345 >>>>> Fax :94 11 2145300 >>>>> Skype : malaka.sampath.silva >>>>> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >>>>> Blog : http://mrmalakasilva.blogspot.com/ >>>>> >>>>> WSO2, Inc. >>>>> lean . enterprise . middleware >>>>> http://www.wso2.com/ >>>>> http://www.wso2.com/about/team/malaka-silva/ >>>>> <http://wso2.com/about/team/malaka-silva/> >>>>> https://store.wso2.com/store/ >>>>> >>>>> Save a tree -Conserve nature & Save the world for your future. Print >>>>> this email only if it is absolutely necessary. >>>>> >>>> >>>> >>>> >>>> -- >>>> Yours sincerely, >>>> >>>> Willian Antunes >>>> >>> >>> >>> >>> -- >>> Yours sincerely, >>> >>> Willian Antunes >>> >> >> >> >> -- >> >> Best Regards, >> >> Malaka Silva >> Senior Tech Lead >> M: +94 777 219 791 >> Tel : 94 11 214 5345 >> Fax :94 11 2145300 >> Skype : malaka.sampath.silva >> LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 >> Blog : http://mrmalakasilva.blogspot.com/ >> >> WSO2, Inc. >> lean . enterprise . middleware >> http://www.wso2.com/ >> http://www.wso2.com/about/team/malaka-silva/ >> <http://wso2.com/about/team/malaka-silva/> >> https://store.wso2.com/store/ >> >> Save a tree -Conserve nature & Save the world for your future. Print this >> email only if it is absolutely necessary. >> > > > > -- > Atenciosamente, > > Willian Antunes > -- Best Regards, Malaka Silva Senior Tech Lead M: +94 777 219 791 Tel : 94 11 214 5345 Fax :94 11 2145300 Skype : malaka.sampath.silva LinkedIn : http://www.linkedin.com/pub/malaka-silva/6/33/77 Blog : http://mrmalakasilva.blogspot.com/ WSO2, Inc. lean . enterprise . middleware http://www.wso2.com/ http://www.wso2.com/about/team/malaka-silva/ <http://wso2.com/about/team/malaka-silva/> https://store.wso2.com/store/ Save a tree -Conserve nature & Save the world for your future. Print this email only if it is absolutely necessary.
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
