On Sun, Jun 5, 2016 at 9:56 AM, Harsha Kumara <hars...@wso2.com> wrote:

> Yes AFAIK it won't add any processing delay from CEP side if we don't
> access any data in the json map. Since we have to go through header maps
> and extract the query param this will add delay for data publishing side.
> We can enable this by default. I think it's better to have the option to
> disable.
>
>
If you take the processing side, we are converting these properties which
coming as json in to map to perform necessary processing.. And, there might
be slight impact due to json string size but IMO it is negligible..

Thanks,
Mohan


> Thanks,
> Harsha
>
> On Sat, Jun 4, 2016 at 1:19 PM, Nuwan Dias <nuw...@wso2.com> wrote:
>
>> Why would we have to check if there are conditions which require query
>> params? Or headers? I think we should publish them anyway. Does it cause a
>> performance impact to send additional data to CEP? I don't think getting
>> those data from the request has an overhead.
>>
>> Thanks,
>> NuwanD.
>>
>> On Sat, Jun 4, 2016 at 10:40 AM, Harsha Kumara <hars...@wso2.com> wrote:
>>
>>> Hi Ushani,
>>>
>>> We add that property because, sometime users may not need publishing the
>>> query params to the CEP as they don't have policies associated with them.
>>> Going through the policies applied for a particular API and determine it
>>> has query param conditions and then publishing the query param to the CEP
>>> is expensive. So we have added those configurations.
>>>
>>>
>>> On Sat, Jun 4, 2016 at 7:46 AM, Ushani Balasooriya <ush...@wso2.com>
>>> wrote:
>>>
>>>> Additionaly why do we need to control EnableQueryParamConditions via
>>>> api-manager.xml when we have a on/off switch button to each conditional
>>>> header in Advanced throttling configuration UI?
>>>> On Jun 4, 2016 7:24 AM, "Ushani Balasooriya" <ush...@wso2.com> wrote:
>>>>
>>>>> Hi Amila,
>>>>>
>>>>> So these configurations will be applicable across all tenants?
>>>>>
>>>>> Akso I think it would be better if we can hide Conditional groups when
>>>>> EnableHeaderConditions is set to false or make them disable. Likewise will
>>>>> it be possible to have UI level improvements to notify the admin? Just a
>>>>> thought.
>>>>>
>>>> Yes this would be a good improvement to have in the UI.
>>>
>>>> Thanks,
>>>>> On Jun 3, 2016 11:00 PM, "Amila De Silva" <ami...@wso2.com> wrote:
>>>>>
>>>>>> Hi Ushani,
>>>>>>
>>>>>> For the new throttling to work you first have to
>>>>>> set EnableAdvanceThrottling to true. When EnableHeaderConditions is set 
>>>>>> to
>>>>>> true, all the headers in the incoming message will be published to the 
>>>>>> CEP.
>>>>>> Similarly Setting EnableJWTClaimConditions and EnableQueryParamConditions
>>>>>> to true would publish JWT claims and the query parameters coming with the
>>>>>> request to the CEP. In the latest pack, spike arrest is only enabled
>>>>>> through the UI, so there's no config element for that.
>>>>>>
>>>>>> On Fri, Jun 3, 2016 at 6:35 PM, Ushani Balasooriya <ush...@wso2.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Hi APIM Team,
>>>>>>>
>>>>>>> It would be highly appreciated, if you can let us know the
>>>>>>> parameters that need to be enabled in api-manager.xml when working with
>>>>>>> throttling since the documents are not ready yet.
>>>>>>>
>>>>>>> E.g., Spike arrest policy parameter, Query param parameter.
>>>>>>>
>>>>>>>
>>>>>>> Thanks and regards,
>>>>>>> --
>>>>>>> *Ushani Balasooriya*
>>>>>>> Senior Software Engineer - QA;
>>>>>>> WSO2 Inc; http://www.wso2.com/.
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> You received this message because you are subscribed to the Google
>>>>>>> Groups "WSO2 Documentation Group" group.
>>>>>>> To unsubscribe from this group and stop receiving emails from it,
>>>>>>> send an email to documentation+unsubscr...@wso2.com.
>>>>>>> For more options, visit
>>>>>>> https://groups.google.com/a/wso2.com/d/optout.
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Amila De Silva*
>>>>>>
>>>>>> WSO2 Inc.
>>>>>> mobile :(+94) 775119302
>>>>>>
>>>>>>
>>>
>>>
>>> --
>>> Harsha Kumara
>>> Software Engineer, WSO2 Inc.
>>> Mobile: +94775505618
>>> Blog:harshcreationz.blogspot.com
>>>
>>
>>
>>
>> --
>> Nuwan Dias
>>
>> Technical Lead - WSO2, Inc. http://wso2.com
>> email : nuw...@wso2.com
>> Phone : +94 777 775 729
>>
>
>
>
> --
> Harsha Kumara
> Software Engineer, WSO2 Inc.
> Mobile: +94775505618
> Blog:harshcreationz.blogspot.com
>



-- 
*V. Mohanadarshan*
*Associate Tech Lead,*
*Data Technologies Team,*
*WSO2, Inc. http://wso2.com <http://wso2.com> *
*lean.enterprise.middleware.*

email: mo...@wso2.com
phone:(+94) 771117673
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to