Hi Tanya, As the comment says, it is to make the patch Jo has done earlier compatible with the lazy session creation (which is a memory improvement).
The code line [2] is not useless. It has a "side effect" [3]. Some refactoring is good, but I believe we cannot remove the line completely. If you do it might break any place has getSession(false). I believe such places were there in AM (to avoid session fixation) so please look into that before removing. [1] https://github.com/wso2/jaggery/commit/70b7c1de5abe4752b880747a597651b8f551812b [2] https://github.com/wso2/jaggery/blob/9711dd223601d8d3107bf4fea4acedad0b73d7be/components/hostobjects/org.jaggeryjs.hostobjects.web/src/main/java/org/jaggeryjs/hostobjects/web/RequestHostObject.java#L657 [3] http://stackoverflow.com/questions/30980616/difference-between-request-getsession-request-getsessiontrue On Fri, Jul 1, 2016 at 8:03 AM, Tanya Madurapperuma <[email protected]> wrote: > Hi, > > Any reason for this [1] > > [1] > https://github.com/wso2/jaggery/commit/9711dd223601d8d3107bf4fea4acedad0b73d7be > > Thanks, > Tanya > > -- > Tanya Madurapperuma > > Senior Software Engineer, > WSO2 Inc. : wso2.com > Mobile : +94718184439 > Blog : http://tanyamadurapperuma.blogspot.com > -- With regards, *Manu*ranga Perera. phone : 071 7 70 20 50 mail : [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
