Hi Niranjan, We are trying to create a p2-feature for our UUF sample application >>> "features-app". It has the artifactId >>> "org.wso2.carbon.uuf.features-app.feature". >>> When we build the feature, it creates a directory inside the zip file, with >>> the name org.wso2.carbon.uuf_1.0.0.SNAPSHOT instead >>> of org.wso2.carbon.uuf.features-app_1.0.0.SNAPSHOT. When we renamed our >>> feature's name to "Features-app.feature", it is working fine. >>> >> IMO we should not name features like this. All WSO2 features end with > ".feature", therefore having the same name within the artifactId again is > not correct. I would suggest to have artifiactId as > "org.wso2.carbon.uuf.app.feature". WDYT? > This feature packs an UUF web app and that web app's name is "Features App" (this sample web app demonstrates different features in UUF). That's why the artifact ID is "org.wso2.carbon.uuf.sample.features-app.feature".
Thanks. On Mon, Aug 8, 2016 at 5:49 PM, Prabushi Samarakoon <[email protected]> wrote: > Hi Niranjan, > > On Mon, Aug 8, 2016 at 5:48 PM, Prabushi Samarakoon <[email protected]> > wrote: > >> >> >> On Mon, Aug 8, 2016 at 4:47 PM, Niranjan Karunanandham <[email protected] >> > wrote: >> >>> Hi Prabushi, >>> >>> >>> >>> On Mon, Aug 8, 2016 at 4:37 PM, Chanaka Cooray <[email protected]> >>> wrote: >>> >>>> Hi Prabushi, >>>> >>>> This seems to be an issue with the carbon feature plugin. In the >>>> FeatureResourceBundle class, it splits the name of the feature by >>>> ".feature" string[1]. Can you create a JIRA for this please? >>>> >>>> [1] https://github.com/wso2/carbon-maven-plugins/blob/master >>>> /carbon-feature-plugin/src/main/java/org/wso2/maven/p2/featu >>>> re/generate/FeatureResourceBundle.java#L72 >>>> >>>> Thanks, >>>> Chanaka. >>>> >>>> On Mon, Aug 8, 2016 at 4:10 PM, Prabushi Samarakoon <[email protected] >>>> > wrote: >>>> >>>>> Hi all, >>>>> >>>>> We are trying to create a p2-feature for our UUF sample application >>>>> "features-app". It has the artifactId >>>>> "org.wso2.carbon.uuf.features-app.feature". >>>>> When we build the feature, it creates a directory inside the zip file, >>>>> with >>>>> the name org.wso2.carbon.uuf_1.0.0.SNAPSHOT instead >>>>> of org.wso2.carbon.uuf.features-app_1.0.0.SNAPSHOT. When we renamed >>>>> our feature's name to "Features-app.feature", it is working fine. >>>>> >>>> IMO we should not name features like this. All WSO2 features end with >>> ".feature", therefore having the same name within the artifactId again is >>> not correct. I would suggest to have artifiactId as >>> "org.wso2.carbon.uuf.app.feature". WDYT? >>> Here we are trying to create a p2-feature for our web application >>> called "features-app" which represents the existing features of UUF. That'a >>> why we have the name "org.wso2.carbon.uuf.features-app.feature". >>> Currently we use this convention for the sample applications in UUF. >>> >>>> >>>>> It seems, the plugin takes the name of the feature up to the first >>>>> ".feature". It doesn't allow to have a name such as >>>>> ".featureXXXX.feature". Because of this reason we cannot get this feature >>>>> into the distribution directory of our product. Is there a way to solve >>>>> this issue? >>>>> >>>> As suggested by Chanaka please create a JIRA in carbon-maven-plugins[1]. >>> >> Created the JIRA [2] >> >>> >>> >>>> >>>>> Thanks and Regards >>>>> >>>>> -- >>>>> *Prabushi Samarakoon* >>>>> Software Engineer >>>>> Mobile: +94715434580 >>>>> Email: [email protected] >>>>> >>>> >>>> >>>> >>>> -- >>>> Chanaka Cooray >>>> Software Engineer, WSO2 Inc. http://wso2.com >>>> Email: [email protected] >>>> Mobile: +94713149860 >>>> <https://wso2.com/signature> >>>> >>> >>> [1] - https://wso2.org/jira/browse/CMVNPLG >>> >>> Regards, >>> Nira >>> >>> -- >>> >>> >>> *Niranjan Karunanandham* >>> Associate Technical Lead - WSO2 Inc. >>> WSO2 Inc.: http://www.wso2.com >>> >>> >> >> >> -- >> *Prabushi Samarakoon* >> Software Engineer >> Mobile: +94715434580 >> Email: [email protected] >> > > [2] - https://wso2.org/jira/browse/CMVNPLG-13 > > -- > *Prabushi Samarakoon* > Software Engineer > Mobile: +94715434580 > Email: [email protected] > -- Sajith Janaprasad Ariyarathna Software Engineer; WSO2, Inc.; http://wso2.com/ <https://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
