Hi Abimaran, The carbon-feature-repository is a common repository contributed by all the product people, and there is a considerable amount of effort going on to keep it cleaner as possible. PR verification is one part of it. The reason for your PR[1] to get delayed is basically, it doesn't show up in the online Github diff, as it has a considerable amount of commits. which needed some additional effort to go one by one and identify the issues (which I replied earlier), which caused the verification harder and time consuming. Please refer PR[50] which is a clean PR, which makes the verification much faster and easier. The person who verifies it can identify the changes just looking at the diff.
We expect products teams to verify the changes first and send a clean PR, So, it won't bounce back and forth for corrections. [1] https://github.com/wso2/carbon-feature-repository/pull/49/files [2] https://github.com/wso2/carbon-feature-repository/pull/50/files Thanks, Jayanga. *Jayanga Dissanayake* Associate Technical Lead WSO2 Inc. - http://wso2.com/ lean . enterprise . middleware email: [email protected] mobile: +94772207259 <http://wso2.com/signature> On Thu, Aug 25, 2016 at 12:08 PM, Abimaran Kugathasan <[email protected]> wrote: > Hi Jayanga, > > I have reordered the features based on alphabet, also, fixed the merge > conflicts. > > Can you please merge it soon? > > PS : Why can't we merge the PRs based on when they sent? I had nearly more > than 70 merge conflicts to resolve since PR 50 was merged before PR 49 > merged. > > On Thu, Aug 25, 2016 at 11:23 AM, Jayanga Dissanayake <[email protected]> > wrote: > >> Hi Abimaran, >> >> In your PR, following entries are in wrong places. >> 1. org.wso2.carbon.apimgt:org.wso2.apimgt.publisher.category.feature >> 2. org.wso2.carbon.apimgt:org.wso2.apimgt.store.category.feature >> >> Please correct the entries and resend the PR. >> >> Thanks, >> Jayanga. >> >> *Jayanga Dissanayake* >> Associate Technical Lead >> WSO2 Inc. - http://wso2.com/ >> lean . enterprise . middleware >> email: [email protected] >> mobile: +94772207259 >> <http://wso2.com/signature> >> >> On Thu, Aug 25, 2016 at 10:38 AM, Niranjan Karunanandham < >> [email protected]> wrote: >> >>> [Adding Jayanga] >>> >>> Hi Jayanga, >>> >>> Can you look into this? >>> >>> Regards, >>> Nira >>> >>> On Thu, Aug 25, 2016 at 10:35 AM, Abimaran Kugathasan <[email protected] >>> > wrote: >>> >>>> Hi Kavitha, >>>> >>>> API Key Manager 5.0.3 isn't compatible with IS 5.2.0. I have sent PR >>>> [1] with relevant features of APIM 2.0 which yet to be merged. >>>> >>>> @Niranjan, >>>> >>>> Can you please merge it soon possible? >>>> >>>> [1] : https://github.com/wso2/carbon-feature-repository/pull/49 >>>> >>>> On Thu, Aug 25, 2016 at 10:24 AM, Kavitha Subramaniyam < >>>> [email protected]> wrote: >>>> >>>>> Hi Harsha/ Darshana, >>>>> >>>>> The reason I tried 5.0.3 feature is the given repository[1] listed >>>>> only the 'API Key Manager 5.0.3' feature after added to IS server. Do I >>>>> need to get the repo from different location? >>>>> >>>>> [1] http://product-dist.wso2.com/p2/carbon/releases/wilkes/ >>>>> >>>>> Thanks, >>>>> >>>>> On Thu, Aug 25, 2016 at 7:21 AM, Darshana Gunawardana < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi Harsha, >>>>>> >>>>>> Sorry, my understanding was APIM 2.0.0 KM version is 5.0.3. As per >>>>>> your above reply it seems to be 6.0.4. >>>>>> >>>>>> IS 5.2.0 should compatible with APIM 2.0.0 for KM installation. So we >>>>>> should try KM 6.0.4 feature installation in IS 5.2.0. @Kavitha : Can >>>>>> you please try that. >>>>>> >>>>>> Thanks, >>>>>> >>>>>> On Wed, Aug 24, 2016 at 11:47 PM, Harsha Kumara <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Hi Darshana, >>>>>>> >>>>>>> It was due to version ranges of dependent feature that we specified >>>>>>> in the key manager features doesn't match with feature version in IS >>>>>>> 5.2.0-beta. We also haven't had a deep look on installing 5.0.3 version >>>>>>> on >>>>>>> IS 5.2.0 releases. >>>>>>> >>>>>>> @kavitha Any reason we going to try 5.0.3 features with IS 5.2.0 >>>>>>> beta instead of trying latest APIM feature versions which is 6.0.4. >>>>>>> During >>>>>>> the latest release we installed 6.0.4 features on IS 5.2.0 release. >>>>>>> >>>>>>> Thanks, >>>>>>> Harsha >>>>>>> >>>>>>> On Wed, Aug 24, 2016 at 11:10 PM, Darshana Gunawardana < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi Harsha, >>>>>>>> >>>>>>>> Can you bit explain what was the issue? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> On Wed, Aug 24, 2016 at 11:03 PM, Harsha Kumara <[email protected]> >>>>>>>> wrote: >>>>>>>> >>>>>>>>> Hi Kavitha, >>>>>>>>> >>>>>>>>> We won't be able to install 5.0.3 features on top of IS 5.2.0-beta >>>>>>>>> due to dependency issues. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Harsha >>>>>>>>> >>>>>>>>> On Wed, Aug 24, 2016 at 5:52 PM, Kavitha Subramaniyam < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Thanks Kasun. >>>>>>>>>> >>>>>>>>>> On Wed, Aug 24, 2016 at 5:50 PM, Kavitha Subramaniyam < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Found a public jira[1] created and updated the latest comment >>>>>>>>>>> [1] https://wso2.org/jira/browse/IDENTITY-4842 >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> On Wed, Aug 24, 2016 at 5:21 PM, Kavitha Subramaniyam < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi IS team, >>>>>>>>>>>> >>>>>>>>>>>> Here I'm using IS 5.2.0 beta2 (24/08 build) pack and p2 repo >>>>>>>>>>>> (4.4.7 - P2 Repo - WSO2 API Manager 2.0.0) available here [1]. >>>>>>>>>>>> Once the repo added, I could find the feature list 'API Key >>>>>>>>>>>> Manager 5.0.3' and I was trying to install it; But cannot go with >>>>>>>>>>>> next and >>>>>>>>>>>> there were no features to be installed (feature.jpeg showing the >>>>>>>>>>>> message >>>>>>>>>>>> displayed). >>>>>>>>>>>> >>>>>>>>>>>> Why this message comes and what would be done to install the >>>>>>>>>>>> features success? >>>>>>>>>>>> >>>>>>>>>>>> [1] http://wso2.com/products/carbon/release-matrix/ >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Kavitha.S >>>>>>>>>>>> *Software Engineer -QA* >>>>>>>>>>>> Mobile : +94 (0) 771538811 <%2B94%20%280%29%20773%20451194> >>>>>>>>>>>> [email protected] <[email protected]> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Kavitha.S >>>>>>>>>>> *Software Engineer -QA* >>>>>>>>>>> Mobile : +94 (0) 771538811 <%2B94%20%280%29%20773%20451194> >>>>>>>>>>> [email protected] <[email protected]> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Kavitha.S >>>>>>>>>> *Software Engineer -QA* >>>>>>>>>> Mobile : +94 (0) 771538811 <%2B94%20%280%29%20773%20451194> >>>>>>>>>> [email protected] <[email protected]> >>>>>>>>>> >>>>>>>>>> _______________________________________________ >>>>>>>>>> Dev mailing list >>>>>>>>>> [email protected] >>>>>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Harsha Kumara >>>>>>>>> Software Engineer, WSO2 Inc. >>>>>>>>> Mobile: +94775505618 >>>>>>>>> Blog:harshcreationz.blogspot.com >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Regards, >>>>>>>> >>>>>>>> >>>>>>>> *Darshana Gunawardana*Associate Technical Lead >>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>> >>>>>>>> *E-mail: [email protected] <[email protected]>* >>>>>>>> *Mobile: +94718566859 <%2B94718566859>*Lean . Enterprise . >>>>>>>> Middleware >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Harsha Kumara >>>>>>> Software Engineer, WSO2 Inc. >>>>>>> Mobile: +94775505618 >>>>>>> Blog:harshcreationz.blogspot.com >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> >>>>>> >>>>>> *Darshana Gunawardana*Associate Technical Lead >>>>>> WSO2 Inc.; http://wso2.com >>>>>> >>>>>> *E-mail: [email protected] <[email protected]>* >>>>>> *Mobile: +94718566859 <%2B94718566859>*Lean . Enterprise . Middleware >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Kavitha.S >>>>> *Software Engineer -QA* >>>>> Mobile : +94 (0) 771538811 <%2B94%20%280%29%20773%20451194> >>>>> [email protected] <[email protected]> >>>>> >>>>> _______________________________________________ >>>>> Dev mailing list >>>>> [email protected] >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Thanks >>>> Abimaran Kugathasan >>>> Senior Software Engineer - API Technologies >>>> >>>> Email : [email protected] >>>> Mobile : +94 773922820 >>>> >>>> <http://stackoverflow.com/users/515034> >>>> <http://lk.linkedin.com/in/abimaran> >>>> <http://www.lkabimaran.blogspot.com/> <https://github.com/abimarank> >>>> <https://twitter.com/abimaran> >>>> >>>> >>> >>> >>> -- >>> >>> >>> *Niranjan Karunanandham* >>> Associate Technical Lead - WSO2 Inc. >>> WSO2 Inc.: http://www.wso2.com >>> >>> >> > > > -- > Thanks > Abimaran Kugathasan > Senior Software Engineer - API Technologies > > Email : [email protected] > Mobile : +94 773922820 > > <http://stackoverflow.com/users/515034> > <http://lk.linkedin.com/in/abimaran> > <http://www.lkabimaran.blogspot.com/> <https://github.com/abimarank> > <https://twitter.com/abimaran> > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
