Hi Hasitha, Please find the PR for adding the new properties to the broker.xml file [1].
[1]. https://github.com/wso2/carbon-business-messaging/pull/336 On Sun, Aug 28, 2016 at 8:23 PM, Isuru Haththotuwa <[email protected]> wrote: > Hi Hasitha, > > On Sun, Aug 28, 2016 at 7:30 AM, Hasitha Hiranya <[email protected]> > wrote: > >> Hi, >> >> Thank You, Isuru...!! >> >> If you add a new property to broker.xml config file, that file needs a >> update as well. So broker.xml of carbon-business-messaging [1] has to be >> changed I guess. Please add a proper description to the property in the >> file for the parameter you are adding. >> > Thanks, will do and send a PR. > >> >> [1]. https://github.com/wso2/carbon-business-messaging/blob/ >> master/features/andes/org.wso2.carbon.andes.server.featu >> re/resources/conf/broker.xml >> >> Thanks >> >> On Fri, Aug 26, 2016 at 8:15 PM, Imesh Gunaratne <[email protected]> wrote: >> >>> [+ Ramith] >>> >>> Great work Isuru!! Well written!! >>> I think it might be useful for explaining why this feature was needed in >>> the PR description. >>> >>> Thanks! >>> >>> On Fri, Aug 26, 2016 at 5:37 PM, Isuru Haththotuwa <[email protected]> >>> wrote: >>> >>>> Hi MB team, >>>> >>>> Please review the P/R for $subject [1], for the jira ticket reported at >>>> [2]. I'm yet to write a test for this, will send a separate P/R once done. >>>> >>>> [1]. https://github.com/wso2/andes/pull/685 >>>> >>>> [2]. https://wso2.org/jira/browse/MB-1736 >>>> >>>> >>>> -- >>>> Thanks and Regards, >>>> >>>> Isuru H. >>>> +94 716 358 048 >>>> >>>> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Imesh Gunaratne* >>> Software Architect >>> WSO2 Inc: http://wso2.com >>> T: +94 11 214 5345 M: +94 77 374 2057 >>> W: https://medium.com/@imesh TW: @imesh >>> lean. enterprise. middleware >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> [email protected] >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Hasitha Abeykoon* >> Senior Software Engineer; WSO2, Inc.; http://wso2.com >> *cell:* *+94 719363063* >> *blog: **abeykoon.blogspot.com* <http://abeykoon.blogspot.com> >> >> > > > -- > Thanks and Regards, > > Isuru H. > +94 716 358 048* <http://wso2.com/>* > > > -- Thanks and Regards, Isuru H. +94 716 358 048* <http://wso2.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
