Hi Sajith, On Fri, Sep 2, 2016 at 7:41 AM, Sajith Kariyawasam <[email protected]> wrote:
> Hi Isuru, > > Yes you are correct, this profile needs puppet to be installed. > Generating the distribution just as a tarball would not be enough, since > the puppet build command generates the exact distribution compatible with > puppet forge. However, the difference seems to be that, 'puppet module > build' adds a new file, checksums.json, with checksums of all the files. We > could use the assembly plugin and generate the checksums and packaged into > the distribution, but I don't think that way is scalable because, if they > do a change in the future to include some other files, we will have to > change our pom files as well. > Agreed on using puppet module build for generating archives to be distributed via puppet forge. But for testing purposes of puppet modules, we do not need the meta information required by puppet forge. Therefore, for development and testing purposes, IMHO we should support creating a puppet module archive even without installing puppet in a local machine. In a nutshell: 1. distributing via puppet forge - use the mvn -P <profile> to build the archive, with relevant meta information (puppet required) 2. For testing/development purposes - build with mvn clean install to generate the archive (puppet not required) WDYT? > > Thanks, > Sajith > > On Fri, Sep 2, 2016 at 6:09 AM, Isuru Haththotuwa <[email protected]> wrote: > >> Hi Sajith, >> >> Please correct me if I'm wrong, AFAIU This profile requires puppet to be >> installed to run the 'puppet module build' command. Can't we use mvn >> assembly plugin to generate puppet module distribution? >> >> >> On Thu, Sep 1, 2016 at 6:40 PM, Sajith Kariyawasam <[email protected]> >> wrote: >> >>> Hi Devs, >>> >>> For a puppet module to be published into puppet forge [1], puppet module >>> need to be built using 'puppet module build' command to create the >>> distribution. >>> >>> I was looking for a 'maven-puppet' plugin to do the task, but couldn't >>> find any suitable plugin, therefore I have introduced a Maven profile [2], >>> which uses exec-plugin >>> and executes the puppet command, and generate the distribution >>> (wso2-wso2bps-3.5.1.tar.gz) if that profile has enabled. >>> >>> For eg, *"mvn clean install -P puppet-build "* >>> >>> Appreciate your thoughts on this ! >>> >>> [1] https://forge.puppet.com/ >>> [2] https://github.com/wso2/puppet-bps/blob/master/pom.xml#L80-L110 >>> >>> >>> Thanks, >>> Sajith >>> >>> >>> -- >>> Sajith Kariyawasam >>> *Committer and PMC member, Apache Stratos, * >>> *WSO2 Inc.; http://wso2.com <http://wso2.com>* >>> *Mobile: 0772269575 <0772269575>* >>> >> >> >> >> -- >> Thanks and Regards, >> >> Isuru H. >> +94 716 358 048* <http://wso2.com/>* >> >> >> > > > -- > Sajith Kariyawasam > *Associate Tech Lead* > *WSO2 Inc.; http://wso2.com <http://wso2.com/>* > *Committer and PMC member, Apache Stratos * > *AMIE (SL)* > *Mobile: 0772269575 <0772269575>* > -- Thanks and Regards, Isuru H. +94 716 358 048* <http://wso2.com/>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
