Hi IS team, I noticed few "Builder" classes, which looks like DAO classes. [1][2] Also they are singletons !
Can we change the name to suitable name, as "Builder" suffix is misleading? It give an impression that it support "Builder Pattern" Also I do not think we need singleton there. [1]carbon-identity-mgt/components/org.wso2.carbon.identity.mgt/src/main/java/org/wso2/carbon/identity/mgt/internal/config/connector/ConnectorConfigBuilder.java [2]carbon-identity-mgt/components/org.wso2.carbon.identity.mgt/src/main/java/org/wso2/carbon/identity/mgt/internal/config/domain/DomainConfigBuilder.java Cheers, Ruwan -- *Ruwan Abeykoon* *Associate Director/Architect**,* *WSO2, Inc. http://wso2.com <https://wso2.com/signature> * *lean.enterprise.middleware.*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
