+1 to keep only the HikariCP based implementation. Do we have unit tests for HikariCP based implementation?
On Wed, Nov 30, 2016 at 11:30 AM, Thanuja Uruththirakodeeswaran < [email protected]> wrote: > Thanks a lot all !!! Will remove tomcat implementation. > > Thanks. > > On Wed, Nov 30, 2016 at 11:13 AM, Kishanthan Thangarajah < > [email protected]> wrote: > >> We first started off with tomcat jdbc pool based impl, but later decided >> to move on Hikari due it's performance reliability over tomcat. We can >> safely remove the tomcat impl. >> >> On Tue, Nov 29, 2016 at 2:07 PM, Anjana Fernando <[email protected]> wrote: >> >>> Hi, >>> >>> We ourselves are specifically not. Kicha or Sameera may know, I guess >>> they just implemented both ways initially. I also think we shouldn't have >>> two separate implementations of the same thing, and just get one >>> implementation tested and used properly. >>> >>> Cheers, >>> Anjana. >>> >>> On Tue, Nov 29, 2016 at 1:43 PM, Thanuja Uruththirakodeeswaran < >>> [email protected]> wrote: >>> >>>> Hi Anjana and Team, >>>> >>>> Are we using the tomcat JDBC connection pool implementation[1] in >>>> carbon-datasources repo anywhere? If not, shall we remove it from the repo. >>>> Please give your suggestions. >>>> >>>> [1]. https://github.com/wso2/carbon-datasources/tree/master/ >>>> components/org.wso2.carbon.datasource.core/src/main/java/org >>>> /wso2/carbon/datasource/rdbms/tomcat >>>> >>>> Thanks. >>>> >>>> -- >>>> Thanuja Uruththirakodeeswaran >>>> Software Engineer >>>> WSO2 Inc.;http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> mobile: +94 774363167 >>>> >>>> <http://wso2.com/signature> >>>> >>> >>> >>> >>> -- >>> *Anjana Fernando* >>> Associate Director / Architect >>> WSO2 Inc. | http://wso2.com >>> lean . enterprise . middleware >>> >> >> >> >> -- >> *Kishanthan Thangarajah* >> Technical Lead, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 <+94%2077%20342%206635> >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > > > -- > Thanuja Uruththirakodeeswaran > Software Engineer > WSO2 Inc.;http://wso2.com > lean.enterprise.middleware > > mobile: +94 774363167 <077%20436%203167> > > <http://wso2.com/signature> > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Isuru Perera Associate Technical Lead | WSO2, Inc. | http://wso2.com/ Lean . Enterprise . Middleware about.me/chrishantha Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
