@KasunG We intended 'en-US' as the fall-back locale. But we have done a case-sensitive comparison (basically not doing a case-insensitive comparison) when figuring-out the correct locale. Will fix this soon.
On Thu, Jan 19, 2017 at 9:57 PM, KasunG Gajasinghe <[email protected]> wrote: > > Using the Accept-Language header is fine. But if the header is missing, > there should be a fallback mechanism. You should not simply display the > key. For our purposes, we can treat en-US as the fallback language. > > On Thu, Jan 19, 2017 at 8:08 PM, Denuwanthi De Silva <[email protected]> > wrote: > >> Hi Shan, >> >> Created a git issue [1]. >> >> [1]https://github.com/wso2/carbon-uuf/issues/154 >> >> Thanks >> >> On Thu, Jan 19, 2017 at 8:07 PM, Shan Mahanama <[email protected]> wrote: >> >>> Hi Denuwanthi, >>> >>> Value of this headers are different in the two browsers. This might be >>> the cause. We will look into this. Can you create a git issue for this at >>> [1]? >>> >>> [1] https://github.com/wso2/carbon-uuf >>> >>> Thanks, >>> Shan. >>> >>> On Thu, Jan 19, 2017 at 7:44 PM, Denuwanthi De Silva < >>> [email protected]> wrote: >>> >>>> Hi Shan, >>>> >>>> When check the Accept-Language in safari it shows "en-us" as in the >>>> attached safari.png file. >>>> >>>> When check with firefox it shows "en-US,en;q=0.5" as in the attached >>>> firefox.png file. >>>> >>>> >>>> >>>> Thanks, >>>> >>>> On Thu, Jan 19, 2017 at 7:17 PM, Shan Mahanama <[email protected]> wrote: >>>> >>>>> Hi Denuwanthi, >>>>> >>>>> We check the *Accept-Language* header value in the request to >>>>> identify the locale. Can you check on Safari whether this header is added >>>>> correctly and it's value is correct? It is possible that in Safari >>>>> browser, >>>>> this header is set to some other locale which does not have a properties >>>>> file. >>>>> >>>>> Thanks, >>>>> Shan. >>>>> >>>>> On Thu, Jan 19, 2017 at 5:09 PM, Denuwanthi De Silva < >>>>> [email protected]> wrote: >>>>> >>>>>> Hi, >>>>>> >>>>>> The values we have set from en_US.properties file in 'lang' folder, >>>>>> does not get properly populated when go through the safari browser. >>>>>> Instead of showing the value it shows the key as shown in the >>>>>> atatched image >>>>>> >>>>>> Is this a known issue in UUF or do we have a way to prevent this from >>>>>> happening? >>>>>> >>>>>> Thanks, >>>>>> >>>>>> -- >>>>>> Denuwanthi De Silva >>>>>> Senior Software Engineer; >>>>>> WSO2 Inc.; http://wso2.com, >>>>>> Email: [email protected] >>>>>> Blog: https://denuwanthi.wordpress.com/ >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Shan Mahanama >>>>> >>>>> Software Engineer, WSO2 Inc. http://wso2.com >>>>> <http://l.facebook.com/l.php?u=http%3A%2F%2Fwso2.com&h=gAQEswASa> >>>>> Email: [email protected] >>>>> Mobile: +94 71 2000 498 >>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Denuwanthi De Silva >>>> Senior Software Engineer; >>>> WSO2 Inc.; http://wso2.com, >>>> Email: [email protected] >>>> Blog: https://denuwanthi.wordpress.com/ >>>> >>> >>> >>> >>> -- >>> Shan Mahanama >>> >>> Software Engineer, WSO2 Inc. http://wso2.com >>> <http://l.facebook.com/l.php?u=http%3A%2F%2Fwso2.com&h=gAQEswASa> >>> Email: [email protected] >>> Mobile: +94 71 2000 498 >>> >>> >>> >> >> >> -- >> Denuwanthi De Silva >> Senior Software Engineer; >> WSO2 Inc.; http://wso2.com, >> Email: [email protected] >> Blog: https://denuwanthi.wordpress.com/ >> > > > > -- > > *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > phone: +1 650-745-4499 <(650)%20745-4499>, 77 678 0813 > > -- Sajith Janaprasad Ariyarathna Software Engineer; WSO2, Inc.; http://wso2.com/ <https://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
