Hi Senduran, Yes. We can use a general control message type instead of ping and pong messages. So I removed ping and pong carbon message types from Carbon-Messaging and added new message type ".
Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : [email protected] <[email protected]>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < [email protected]> wrote: > Hi Irunika, > > The above PR has PingCarbonMessage and PongCarbonMessage. It will be > better if you could rename those two classes to generalized name. > > Regards > Senduran > > On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < > [email protected]> wrote: > >> Looks ok. >> >> Senduran/Shafreen, can we merge this PR? >> >> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <[email protected]> >> wrote: >> >>> Hi, >>> Fixed the issues mentioned. >>> Please review and merge. >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : [email protected] <[email protected]>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <[email protected]> >>> wrote: >>> >>>> Noted. >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : [email protected] <[email protected]>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah < >>>> [email protected]> wrote: >>>> >>>>> PR has some formatting issue to be fixed. Can you look into it? >>>>> >>>>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <[email protected] >>>>> > wrote: >>>>> >>>>>> Hi all, >>>>>> Can you please review and merge the PR? >>>>>> >>>>>> Thanks, >>>>>> Irunika >>>>>> >>>>>> *Irunika Weeraratne* >>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>> *Email : [email protected] <[email protected]>* >>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>>> >>>>>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <[email protected] >>>>>> > wrote: >>>>>> >>>>>>> Hi all, >>>>>>> I modified the Carbon-Messaging according to the requirements. >>>>>>> Please review and merge. >>>>>>> https://github.com/wso2/carbon-messaging/pull/40 >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : [email protected] <[email protected]>* >>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> I did necessary changes after the review. >>>>>>>> Please review and merge >>>>>>>> https://github.com/wso2/carbon-messaging/pull/40 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Irunika >>>>>>>> >>>>>>>> *Irunika Weeraratne* >>>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>>> *Email : [email protected] <[email protected]>* >>>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>> >>>>>>>> >>>>>>>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Noted. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Irunika >>>>>>>>> >>>>>>>>> *Irunika Weeraratne* >>>>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>>>> *Email : [email protected] <[email protected]>* >>>>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>>> >>>>>>>>> >>>>>>>>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Adding @dev >>>>>>>>>> >>>>>>>>>> @Irunika, always copy the relevant mailing list. >>>>>>>>>> >>>>>>>>>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> Please review and merge >>>>>>>>>>> https://github.com/wso2/carbon-messaging/pull/39 >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Irunika >>>>>>>>>>> *Irunika Weeraratne* >>>>>>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>>>>>> *Email : [email protected] <[email protected]>* >>>>>>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Kishanthan Thangarajah* >>>>>>>>>> Technical Lead, >>>>>>>>>> Platform Technologies Team, >>>>>>>>>> WSO2, Inc. >>>>>>>>>> lean.enterprise.middleware >>>>>>>>>> >>>>>>>>>> Mobile - +94773426635 <+94%2077%20342%206635> >>>>>>>>>> Blog - *http://kishanthan.wordpress.com >>>>>>>>>> <http://kishanthan.wordpress.com>* >>>>>>>>>> Twitter - *http://twitter.com/kishanthan >>>>>>>>>> <http://twitter.com/kishanthan>* >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Kishanthan Thangarajah* >>>>> Technical Lead, >>>>> Platform Technologies Team, >>>>> WSO2, Inc. >>>>> lean.enterprise.middleware >>>>> >>>>> Mobile - +94773426635 <+94%2077%20342%206635> >>>>> Blog - *http://kishanthan.wordpress.com >>>>> <http://kishanthan.wordpress.com>* >>>>> Twitter - *http://twitter.com/kishanthan >>>>> <http://twitter.com/kishanthan>* >>>>> >>>> >>>> >>> >> >> >> -- >> *Kishanthan Thangarajah* >> Technical Lead, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 <+94%2077%20342%206635> >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > > > -- > *Senduran * > Senior Software Engineer, > WSO2, Inc.; http://wso2.com/ <http://wso2.com/> > Mobile: +94 77 952 6548 <+94%2077%20952%206548> >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
