Hi Malintha, On Tue, Feb 28, 2017 at 8:45 AM, Malintha Amarasinghe <[email protected]> wrote:
> [Re-sending due to "Too many recipients"] > On Tue, Feb 28, 2017 at 8:33 AM, Malintha Amarasinghe <[email protected]> > wrote: > >> Hi, >> >> On Tue, Feb 28, 2017 at 8:20 AM, Abimaran Kugathasan <[email protected]> >> wrote: >> >>> +Dev >>> >>> We need to add this Location Header in all response of HTTP POST >>> requests. >>> >>> There is a confusion whether to add absolute URL or relativeURL [1]. If >>> we add absolute URL, then there can be a problem when a proxy is fronted. >>> >> I guess many proxy services are capable of handling absolute URIs; i.e. >> re-writing the Location header to the proxy URL so that would not be a >> problem I guess. Keeping the absolute URL is easier for the client. >> >> (nginx) https://www.cyberciti.biz/faq/proxy_redirect-change-replace- >> location-refresh-response-headers/ >> (apache proxy) http://www.microhowto.info/howto/configure_apache_as_ >> a_reverse_proxy.html#idp39904 >> >> >>> [1] : https://tools.ietf.org/html/rfc7231#section-7.1.2 >>> >>> On Tue, Feb 28, 2017 at 1:04 AM, Ishara Cooray <[email protected]> wrote: >>> >>>> Hi Fazlan, >>>> >>>> LOCATION_HEADER_INCORRECT(900322, "Invalid URL for location", 500, " >>>> Invalid URL in location header"); >>>> >>> From the code I see this happens when there's an exception happen in the >> server when trying to build a URI object. So that is acually a server side >> error and 500 is correct IMO. But I guess the error description need to be >> changed. May be like Error while obtaining URI for Location header .. >> WDYT? >> > Yes that seems a better description. Will update the PR. And yes 500 should be the correct status since this is not an error in the request and the client is not responsible. > >> Thanks! >> Malintha >> >>> >>>> I think more appropriate error code would be something in 4xx >>>> range(client error), but 500 means it's more like a server error. >>>> >>>> How about using *406* Not Acceptable? >>>> >>>> [1] https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html >>>> >>>> Thanks & Regards, >>>> Ishara Cooray >>>> Senior Software Engineer >>>> Mobile : +9477 262 9512 <+94%2077%20262%209512> >>>> WSO2, Inc. | http://wso2.com/ >>>> Lean . Enterprise . Middleware >>>> >>>> On Mon, Feb 27, 2017 at 10:32 PM, Roshan Wijesena <[email protected]> >>>> wrote: >>>> >>>>> >>>>> On Mon, Feb 27, 2017 at 6:26 PM, Fazlan Nazeem <[email protected]> >>>>> wrote: >>>>> >>>>>> @Roshan, >>>>>> can you review the PR and check whether this violates any concept we >>>>>> discussed during error and exception handling discussion. The usual >>>>>> method >>>>>> had to be altered a bit because we don't have an errorHandler object >>>>>> within >>>>>> the exception object in this case. >>>>>> >>>>> >>>>> This change is fine. >>>>> >>>>> >>>>> -- >>>>> Roshan Wijesena. >>>>> Senior Software Engineer-WSO2 Inc. >>>>> Mobile: *+94719154640 <+94%2071%20915%204640>* >>>>> Email: [email protected] >>>>> *WSO2, Inc. :** wso2.com <http://wso2.com/>* >>>>> lean.enterprise.middleware. >>>>> >>>> >>>> >>> >>> >>> -- >>> Thanks >>> Abimaran Kugathasan >>> Senior Software Engineer - API Technologies >>> >>> Email : [email protected] >>> Mobile : +94 773922820 <+94%2077%20392%202820> >>> >>> <http://stackoverflow.com/users/515034> >>> <http://lk.linkedin.com/in/abimaran> >>> <http://www.lkabimaran.blogspot.com/> <https://github.com/abimarank> >>> <https://twitter.com/abimaran> >>> >>> >> >> >> -- >> Malintha Amarasinghe >> Software Engineer >> *WSO2, Inc. - lean | enterprise | middleware* >> http://wso2.com/ >> >> Mobile : +94 712383306 <+94%2071%20238%203306> >> > > > > -- > Malintha Amarasinghe > Software Engineer > *WSO2, Inc. - lean | enterprise | middleware* > http://wso2.com/ > > Mobile : +94 712383306 <+94%2071%20238%203306> > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Thanks & Regards, Fazlan Nazeem *Software Engineer* *WSO2 Inc* Mobile : +94772338839 <%2B94%20%280%29%20773%20451194> [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
