Done! On 2 March 2017 at 10:31, Kishanthan Thangarajah <[email protected]> wrote:
> Thanks Gokul. Added a review comment on your PR. Please look into it. > > On Tue, Feb 28, 2017 at 5:45 PM, Gokul Balakrishnan <[email protected]> > wrote: > >> Hi, >> >> In our component, we have a piece of code that has a possibility of being >> called from within a Carbon server as well as from outside. This code uses >> the Utils.getCarbonConfigHome() method from the kernel. >> >> In the second case, since the required system property is not found in >> the runtime, it's a given that the call should fail. However, rather than >> failing gracefully, this method throws an NPE since in [1], there's an >> attempt to set a null as a system property. >> >> The proper fix here should be that a null check be introduced and the >> calling party notified (e.g. through an exception). Added the fix at [2]. >> Could you check please? >> >> [1] https://github.com/wso2/carbon-kernel/blob/master/core/src/ >> main/java/org/wso2/carbon/kernel/utils/Utils.java#L67 >> >> [2] https://github.com/wso2/carbon-kernel/issues/1309 >> >> Thanks, >> >> -- >> Gokul Balakrishnan >> Senior Software Engineer, >> WSO2, Inc. http://wso2.com >> M +94 77 5935 789 | +44 7563 570502 <+44%207563%20570502> >> >> > > > -- > *Kishanthan Thangarajah* > Technical Lead, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 <+94%2077%20342%206635> > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- Gokul Balakrishnan Senior Software Engineer, WSO2, Inc. http://wso2.com M +94 77 5935 789 | +44 7563 570502
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
