On Fri, Mar 3, 2017 at 10:05 AM, Anuruddha Liyanarachchi < [email protected]> wrote:
> Hi Imesh, > > Yes. This was encountered after moving to separate repositories. Earlier > we have declared java dependency at wso2base init.pp [1]. > > [1] https://github.com/wso2/puppet-modules/blob/master/ > modules/wso2base/manifests/init.pp#L90 > Thanks Anuruddha! Was there any reason to change that? Thanks Imesh > > On Fri, Mar 3, 2017 at 9:34 AM, Imesh Gunaratne <[email protected]> wrote: > >> Hi Anuruddha, >> >> Is this something we encountered after moving the code to product >> specific repositories? As I can remember this issue was not there earlier >> in puppet-modules repository. >> >> Thanks >> Imesh >> >> On Thu, Mar 2, 2017 at 5:36 PM, Anuruddha Liyanarachchi < >> [email protected]> wrote: >> >>> Hi, >>> >>> Found an alternative way to execute the site.pp by changing puppet apply >>> command used in image-config.sh in docker from [1] to below. >>> >>> From >>> >>>> puppet apply -e "include ${MODULE_NAME}" --hiera_config=/etc/puppet/hie >>>> ra.yaml >>> >>> >>> To >>> >>>> puppet apply /etc/puppet/manifests/site.pp >>>> --hiera_config=/etc/puppet/hiera.yaml >>> >>> >>> We will be following this approach and above PRs can be ignored. The >>> change will only happen in docker-common repo. >>> >>> [1] https://github.com/wso2/docker-common/blob/820c70c4220067493 >>> 14343d3b9e55bdd9a5e0a38/provision/puppet/image-config.sh#L61 >>> >>> >>> >>> On Thu, Mar 2, 2017 at 3:52 PM, Anuruddha Liyanarachchi < >>> [email protected]> wrote: >>> >>>> Hi, >>>> >>>> $subject was noticed when trying to create APIM docker image from >>>> puppet-modules [1]. >>>> >>>> This is happening because when using puppet apply, java module is not >>>> getting invoked because site.pp is not getting executed. >>>> >>>> As a fix, I have included java class in each product puppet module >>>> init.pp and removed it from site.pp in PRs [2] and [3]. The dependency is >>>> added to APIM init.pp from [4]. >>>> >>>> Similarly, we will have to update ESB, IOT and IS puppet modules as >>>> well. >>>> >>>> Kindly suggest if there are any alternatives which we can use to >>>> overcome $subject. >>>> >>>> [1] https://github.com/wso2/puppet-apim/tree/v2.1.0 >>>> [2] https://github.com/wso2/puppet-common/pull/8 >>>> [3] https://github.com/wso2/puppet-base/pull/9 >>>> [4] https://github.com/wso2/puppet-apim/pull/16/files >>>> >>>> -- >>>> *Thanks and Regards,* >>>> Anuruddha Lanka Liyanarachchi >>>> Software Engineer - WSO2 >>>> Mobile : +94 (0) 712762611 >>>> Tel : +94 112 145 345 >>>> a <[email protected]>[email protected] >>>> >>> >>> >>> >>> -- >>> *Thanks and Regards,* >>> Anuruddha Lanka Liyanarachchi >>> Software Engineer - WSO2 >>> Mobile : +94 (0) 712762611 >>> Tel : +94 112 145 345 >>> a <[email protected]>[email protected] >>> >> >> >> >> -- >> *Imesh Gunaratne* >> Software Architect >> WSO2 Inc: http://wso2.com >> T: +94 11 214 5345 M: +94 77 374 2057 <+94%2077%20374%202057> >> W: https://medium.com/@imesh TW: @imesh >> lean. enterprise. middleware >> >> > > > -- > *Thanks and Regards,* > Anuruddha Lanka Liyanarachchi > Software Engineer - WSO2 > Mobile : +94 (0) 712762611 > Tel : +94 112 145 345 > a <[email protected]>[email protected] > -- *Imesh Gunaratne* Software Architect WSO2 Inc: http://wso2.com T: +94 11 214 5345 M: +94 77 374 2057 W: https://medium.com/@imesh TW: @imesh lean. enterprise. middleware
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
