On Thu, Mar 23, 2017 at 12:27 PM, Pushpalanka Jayawardhana <la...@wso2.com> wrote:
> > > On Tue, Mar 21, 2017 at 10:56 AM, Godwin Shrimal <god...@wso2.com> wrote: > >> If we make native claim dialect configurable, will product work by >> changing to different claim dialect ? >> > That should be the expectation if we make the native claim dialect > configurable. > > As of now, we have the native dialect hard coded as at [1]. If make it > configurable, it should come from a configuration file, most suitably > 'domain-config.yaml' file. > Appreciate your inputs soon to move forward, as lot of codes and designs > will be affected by this decision. > Some users may not want to use/return claims with WSO2 prefix ( http://wso2.org/claims) instead they want to use their own prefix ( http://mycompany.com/attributes) so better to make the prefix of default claim dialect configurable. ATM we have hard coded this value and what we should do is provide a ability to override this prefix value per server basis through deployment.yaml, I don't see any reason to related this configuration with domains. Thanks ! > > [1] - https://github.com/wso2/carbon-identity-mgt/blob/ > master/components/org.wso2.carbon.identity.mgt/src/main/ > java/org/wso2/carbon/identity/mgt/impl/util/IdentityMgtConstants.java#L44- > L46 > >> >> Thanks >> Godwin >> >> >> On Mon, Mar 20, 2017 at 4:34 PM, Pushpalanka Jayawardhana <la...@wso2.com >> > wrote: >> >>> +Prabath >>> >>> On Mon, Mar 20, 2017 at 4:33 PM, Pushpalanka Jayawardhana < >>> la...@wso2.com> wrote: >>> >>>> Hi All, >>>> >>>> Have we made a conclusion on this? Are we expecting to make the native >>>> dialect configurable? >>>> Given that we have claim mapping functionality this won't be a >>>> mandatory requirement. But this has the advantage Omindu mentioned against >>>> the complexities introduced by letting this configurable for username, >>>> groupname etc. >>>> >>>> Thanks, >>>> >>>> On Thu, Feb 23, 2017 at 2:13 PM, Omindu Rathnaweera <omi...@wso2.com> >>>> wrote: >>>> >>>>> One of the advantages would be that we can avoid the overhead of claim >>>>> transformation. >>>>> >>>>> Regards, >>>>> Omindu. >>>>> >>>>> On Thu, Feb 23, 2017 at 1:53 PM, Omindu Rathnaweera <omi...@wso2.com> >>>>> wrote: >>>>> >>>>>> Do we need to make the native claim dialect configurable ? AFAIK it >>>>>> is not configurable and we are using a hardcoded constant for the dialect >>>>>> URI (http://wso2.org/claims). >>>>>> >>>>>> >>>>>> Regards, >>>>>> Omindu >>>>>> >>>>>> -- >>>>>> Omindu Rathnaweera >>>>>> Software Engineer, WSO2 Inc. >>>>>> Mobile: +94 771 197 211 <+94%2077%20119%207211> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Omindu Rathnaweera >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94 771 197 211 <077%20119%207211> >>>>> >>>> >>>> >>>> >>>> -- >>>> Pushpalanka. >>>> -- >>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>>> Mobile: +94779716248 >>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/p >>>> ushpalanka/ | Twitter: @pushpalanka >>>> >>>> >>> >>> >>> -- >>> Pushpalanka. >>> -- >>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). >>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ >>> Mobile: +94779716248 >>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/p >>> ushpalanka/ | Twitter: @pushpalanka >>> >>> >>> _______________________________________________ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Godwin Amila Shrimal* >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: *+94772264165* >> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >> twitter: https://twitter.com/godwinamila >> <http://wso2.com/signature> >> > > > > -- > Pushpalanka. > -- > Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). > Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ > Mobile: +94779716248 > Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/ > pushpalanka/ | Twitter: @pushpalanka > > -- Sagara Gunathunga Associate Director / Architect; WSO2, Inc.; http://wso2.com V.P Apache Web Services; http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
