Noticed another problem, in the streaming flow the request interceptors
have been engaged once the streaming has completed [2]. These might need to
be engaged before starting the streaming process.

[2]
https://github.com/wso2/msf4j/blob/master/core/src/main/java/org/wso2/msf4j/internal/router/HttpMethodInfo.java#L386

Thanks

On Fri, Mar 24, 2017 at 5:46 PM, Imesh Gunaratne <[email protected]> wrote:

> The above NPE is fixed in the following PR:
> https://github.com/wso2/msf4j/pull/383/
>
> On Fri, Mar 24, 2017 at 5:35 PM, Imesh Gunaratne <[email protected]> wrote:
>
>> It seems like a NPE is raised in the following scenario:
>>
>> java.lang.NullPointerException
>> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeMethod
>> ResponseInterceptorsForMethods(InterceptorExecutor.java:188)
>> at org.wso2.msf4j.internal.router.HttpMethodInfo.end(HttpMethod
>> Info.java:402)
>> at org.wso2.msf4j.internal.MSF4JMessageProcessor.dispatchMethod
>> (MSF4JMessageProcessor.java:152)
>> at org.wso2.msf4j.internal.MSF4JMessageProcessor.lambda$receive
>> $0(MSF4JMessageProcessor.java:87)
>> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool
>> Executor.java:1142)
>> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo
>> lExecutor.java:617)
>> at java.lang.Thread.run(Thread.java:745)
>>
>> This error is visible in the build in the 
>> HttpServerTest.testSmallFileUpload()
>> test method. However, the test has not failed because the status code
>> returned in this scenario is 200, not 500. This has caused because of the
>> hard coded status code in [1].
>>
>> We might need to cancel this vote and fix this issue.
>>
>> [1] https://github.com/wso2/carbon-transports/blob/master/ht
>> tp/org.wso2.carbon.transport.http.netty/src/main/java/org/
>> wso2/carbon/transport/http/netty/common/Util.java#L95
>>
>> Thanks
>>
>> On Wed, Mar 22, 2017 at 2:27 PM, Eranda Rajapakshe <[email protected]>
>> wrote:
>>
>>> Tested the feature, microservice hot deployment in server mode.
>>>
>>> [x] Stable - go ahead and release
>>>
>>> Thanks,
>>>
>>> On Wed, Mar 22, 2017 at 12:19 PM, Danesh Kuruppu <[email protected]>
>>> wrote:
>>>
>>>> Hi Devs,
>>>>
>>>> This is the 2nd Release Candidate of WSO2 MSF4J(Microservices
>>>> Framework for Java) 2.2.0.
>>>>
>>>> Please download, test the framework and vote. The vote will be open
>>>> for 72 hours or as needed.
>>>> Refer to GitHub readmes for guides.
>>>>
>>>> * Source and binary distribution files:*
>>>> https://github.com/wso2/msf4j/releases/tag/v2.2.0-rc2
>>>>
>>>> *Maven staging repository:*
>>>> https://maven.wso2.org/nexus/content/repositories/orgwso2msf4j-1015
>>>>
>>>> *The tag to be voted upon:*
>>>> https://github.com/wso2/msf4j/tree/v2.2.0-rc2
>>>>
>>>>
>>>> [ ] Broken - do not release (explain why)
>>>> [ ] Stable - go ahead and release
>>>>
>>>> Thank you,
>>>> Platform Team
>>>> --
>>>>
>>>> *Danesh Kuruppu*
>>>> Senior Software Engineer | WSO2
>>>>
>>>> Email: [email protected]
>>>> Mobile: +94 (77) 1690552 <+94%2077%20169%200552>
>>>> Web: WSO2 Inc <https://wso2.com/signature>
>>>>
>>>>
>>>
>>>
>>> --
>>> *Eranda Rajapakshe*
>>> Software Engineer
>>> WSO2 Inc.
>>> Mobile : +94784822608
>>>
>>> _______________________________________________
>>> Dev mailing list
>>> [email protected]
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> *Imesh Gunaratne*
>> Software Architect
>> WSO2 Inc: http://wso2.com
>> T: +94 11 214 5345 M: +94 77 374 2057 <+94%2077%20374%202057>
>> W: https://medium.com/@imesh TW: @imesh
>> lean. enterprise. middleware
>>
>>
>
>
> --
> *Imesh Gunaratne*
> Software Architect
> WSO2 Inc: http://wso2.com
> T: +94 11 214 5345 M: +94 77 374 2057 <+94%2077%20374%202057>
> W: https://medium.com/@imesh TW: @imesh
> lean. enterprise. middleware
>
>


-- 
*Imesh Gunaratne*
Software Architect
WSO2 Inc: http://wso2.com
T: +94 11 214 5345 M: +94 77 374 2057
W: https://medium.com/@imesh TW: @imesh
lean. enterprise. middleware
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to