Hi Illia,

Seems that the return type was changed to void while fixing an issue ([1],
[2]) and the doc comment was not updated accordingly. Can we know your
exact requirement so we can provide an alternative to this?

[1] - https://github.com/wso2/carbon-identity/pull/976
[2] - https://wso2.org/jira/browse/IDENTITY-2558

Regards,
Omindu.


On Mon, Apr 3, 2017 at 3:15 PM, Illia Alifanov <[email protected]>
wrote:

> Dear, WSO2 dev team,
>
>
>
> You have a bit confused situation in carbon-identity source code with
> creatApplication method.
>
>
>
> https://github.com/wso2/carbon-identity/blob/master/
> components/application-mgt/org.wso2.carbon.identity.
> application.mgt/src/main/java/org/wso2/carbon/identity/application/mgt/
> ApplicationManagementAdminService.java
>
>
>
> We can see in comments @return application id
>
> But   *void* in the method signature.
>
>
>
> /**
>
>      * Creates a service provider with basic information.First we need to
> create
>
>      * a role with the
>
>      * application name. Only the users in this role will be able to
> edit/update
>
>      * the application.The
>
>      * user will assigned to the created role.Internal roles used.
>
>      *
>
>      * @param serviceProvider Service provider
>
>      ** *@return application id
>
>      * @throws org.wso2.carbon.identity.application.common.
> IdentityApplicationManagementException
>
>      */
>
>     public *void* createApplication(ServiceProvider serviceProvider)
>
>             throws IdentityApplicationManagementException {
>
>         applicationMgtService = ApplicationManagementService.g
> etInstance();
>
>         applicationMgtService.createApplication(serviceProvider,
> getTenantDomain(), getUsername());
>
>     }
>
>
>
>
>
>
>
> Regards,
>
> Illia.
>
>
>
> ------------------------------
>
> This e-mail may contain privileged and confidential information. If you
> are not the intended recipient, be aware that any use, disclosure, copying
> or distribution of this e-mail or any attachments is prohibited. If you
> have received this e-mail in error, please notify us immediately by
> returning it to the sender and delete this copy from your system. Thank you.
>
> _______________________________________________
> Dev mailing list
> [email protected]
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Omindu Rathnaweera
Senior Software Engineer, WSO2 Inc.
Mobile: +94 771 197 211
_______________________________________________
Dev mailing list
[email protected]
http://wso2.org/cgi-bin/mailman/listinfo/dev

Reply via email to