Thanks Pushpalanka for looking into this. I created the JIRA [1] to track this.
[1] https://wso2.org/jira/browse/IDENTITY-5855 On Fri, Apr 7, 2017 at 10:01 AM, Pushpalanka Jayawardhana <[email protected]> wrote: > Hi, > > *<IdentityOAuthTokenGenerator> *is the latest addition from the two > options which we should continue to use. > *IdentityOAuthTokenGenerator *seems to be introduced to resolve some > limitations in *OAuthTokenGenerator, *but not totally removed for > backward compatibility. > > Anyway logs seems to be misleading and needs correction. > > Thanks, > > On Fri, Apr 7, 2017 at 9:50 AM, Tharindu Edirisinghe <[email protected]> > wrote: > >> Hi Devs, >> >> I need to implement my own OAuth2 token generator/issuer for IS 5.3.0. >> >> For that I wrote a class extending >> *org.wso2.carbon.identity.oauth2.token.OauthTokenIssuerImpl >> *class and put the component into lib directory (non OSGI). >> >> Then in identity.xml file, under <OAuth> tag, I add the tag >> *<IdentityOAuthTokenGenerator>* and engage my custom token >> generator/issuer by adding the fully qualified class name as the value of >> the tag. >> >> Using the playground2 sample, I got the entire flow to working where all >> the methods I have overridden are hit properly. >> >> However, I see the following INFO log. >> >> *[2017-04-07 09:32:32,334] INFO >> {org.wso2.carbon.identity.oauth.config.OAuthServerConfiguration} - The >> default OAuth token issuer will be used. No custom token generator is set.* >> >> I went through the code in [1] and found that the reason for the log is >> that there is no *<OAuthTokenGenerator>* tag in identity.xml which I >> have defined. >> >> So my question is, are the tags *IdentityOAuthTokenGenerator *and >> *OAuthTokenGenerator >> *both serve the same purpose ? or what is the difference. >> >> Also since I have got the flow to working, can I ignore the above info >> log although I am using my own token issuer ? >> >> [1] https://github.com/wso2/carbon-identity/blob/master/componen >> ts/oauth/org.wso2.carbon.identity.oauth/src/main/java/ >> org/wso2/carbon/identity/oauth/config/OAuthServerConfiguration.java >> >> Thanks, >> TharinduE >> >> -- >> >> Tharindu Edirisinghe >> Senior Software Engineer | WSO2 Inc >> Platform Security Team >> Blog : http://tharindue.blogspot.com >> mobile : +94 775181586 <077%20518%201586> >> > > > > -- > Pushpalanka. > -- > Pushpalanka Jayawardhana, B.Sc.Eng.(Hons). > Senior Software Engineer, WSO2 Lanka (pvt) Ltd; wso2.com/ > Mobile: +94779716248 > Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/ > pushpalanka/ | Twitter: @pushpalanka > > -- Tharindu Edirisinghe Senior Software Engineer | WSO2 Inc Platform Security Team Blog : http://tharindue.blogspot.com mobile : +94 775181586
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
