Thank you Kishanthan. On Thu, May 18, 2017 at 9:08 AM, Kishanthan Thangarajah <[email protected] > wrote:
> Merged. > > Thanks, > > On Tue, May 16, 2017 at 10:50 PM, Manuri Amaya Perera <[email protected]> > wrote: > >> Hi Kishanthan, >> >> I have replied to the comments. >> >> Thanks, >> Manuri >> >> On Tue, May 16, 2017 at 10:32 PM, Kishanthan Thangarajah < >> [email protected]> wrote: >> >>> Hi Manuri, >>> >>> Thank you for looking into this. I have added some review comments on >>> the PR. >>> >>> Thanks, >>> >>> On Mon, May 15, 2017 at 10:23 PM, Manuri Amaya Perera <[email protected]> >>> wrote: >>> >>>> Hi Carbon Team, >>>> >>>> Please review and merge this PR[1] for $subject. The tests were written >>>> before C5 5.0.0 release but later were reverted due to a test failure in >>>> windows caused by a bug in the maven archetype plugin. Now, after more than >>>> an year an archetype plugin release has taken place with this bug fixed, so >>>> I upgraded the plugin version and added the tests back. >>>> >>>> [1] https://github.com/wso2/carbon-kernel/pull/1370 >>>> >>>> Thanks, >>>> Manuri >>>> >>>> -- >>>> >>>> *Manuri Amaya Perera* >>>> >>>> *Software Engineer* >>>> >>>> *WSO2 Inc.* >>>> >>>> *Blog: http://manuriamayaperera.blogspot.com >>>> <http://manuriamayaperera.blogspot.com>* >>>> >>>> >>>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Technical Lead, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 <+94%2077%20342%206635> >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >> >> >> >> -- >> >> *Manuri Amaya Perera* >> >> *Software Engineer* >> >> *WSO2 Inc.* >> >> *Blog: http://manuriamayaperera.blogspot.com >> <http://manuriamayaperera.blogspot.com>* >> >> >> > > > -- > *Kishanthan Thangarajah* > Technical Lead, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 <+94%2077%20342%206635> > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > -- *Manuri Amaya Perera* *Software Engineer* *WSO2 Inc.* *Blog: http://manuriamayaperera.blogspot.com <http://manuriamayaperera.blogspot.com>*
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
