I think your fix[1] will solve this. Anything else we need to do?
[1] https://github.com/wso2/siddhi/pull/452
Regards
Suho
On Fri, Jul 14, 2017 at 3:40 PM, Minudika Malshan <minud...@wso2.com> wrote:
> Hi,
>
> Currently siddhi only identifies option parameter values defined only with
> a place holder. But it does not identifies option parameters as dynamic if
> the place holder is placed in the middle of a string. [1]
>
> For example :
> *@sink(type='file', uri={{symbol}}'*
> In this case, *uri* will be identified as a dynamic option.
>
> *@sink(type='file', uri='/abc/{{symbol}}.json*
> In this case, *uri* will not be taken as a dynamic parameter even we have
> registered as a supported dynamic option.
>
> I have made a fix for this issue, but need to confirm it won't be an issue
> for other implementations.
>
> Shall we accept both above types of values as dynamic options?
>
> [1] https://github.com/wso2/siddhi/blob/master/modules/
> siddhi-core/src/main/java/org/wso2/siddhi/core/util/parser/
> helper/DefinitionParserHelper.java#L670
>
> Thanks and regards!
>
> --
> *Minudika Gammanpila*
> Software Engineer - WSO2
>
> Email : minud...@wso2.com
> Mobile : +94715659887 <071%20565%209887>
> Web : http://wso2.com <http://wso2.com/signature>
>
--
*S. Suhothayan*
Associate Director / Architect
*WSO2 Inc. *http://wso2.com
* <http://wso2.com/>*
lean . enterprise . middleware
*cell: (+94) 779 756 757 | blog: http://suhothayan.blogspot.com/
<http://suhothayan.blogspot.com/>twitter: http://twitter.com/suhothayan
<http://twitter.com/suhothayan> | linked-in:
http://lk.linkedin.com/in/suhothayan <http://lk.linkedin.com/in/suhothayan>*
_______________________________________________
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
