Hi Abilashini, I have added a few review comments for PR's. Please have a look and fix.
Regards DimuthuD On Thu, Aug 10, 2017 at 8:07 PM, Ishara Karunarathna <[email protected]> wrote: > Hi, > > Thanks Abilashini, will review the PR > > -Ishara > > On Wed, Aug 9, 2017 at 1:05 PM, Abilashini Thiyagarajah < > [email protected]> wrote: > >> Hi, >> >> Please find the PR of the integration test cases [1] for the >> implementation of OAuth DCRM protocol [2]. >> >> Covered test cases in this PR as follow, >> >> 1. Successful Read service provider >> 2. Read request with invalid client ID in the endpoint URL >> 3. Successful update service provider >> 4. Update request with invalid client ID in the endpoint URL >> 5. Update request with invalid client ID >> 6. Update request with invalid client secret >> 7. Update request without grant type >> 8. Update request with invalid grant type >> 9. Successful Delete service provider >> 10. Delete request with invalid client ID in the endpoint URL >> >> Please share your feedback to improve further >> >> [1] https://github.com/wso2/product-is/pull/1293 >> [2] https://github.com/wso2-extensions/identity-inbound-auth >> -oauth/pull/396 >> >> Best Regards, >> Abilashini >> >> *Thiyagarajah Abilashini* >> Student >> Department of Computer Science and Engineering >> University of Moratuwa, Sri Lanka >> > > > > -- > Ishara Karunarathna > Associate Technical Lead > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > email: [email protected], blog: isharaaruna.blogspot.com, mobile: > +94717996791 <071%20799%206791> > > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Dimuthu De Lanerolle Software Engineer WSO2 Inc. lean . enterprise . middlewear. http://wso2.com/ Tel. : +94 11 2145345 Fax : +94 11 2145300 email : [email protected]
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
