Hi Dilan, I have done the changes and successfully build the component and kernel with the tests.
Thanks, Ashen On Fri, Aug 11, 2017 at 8:09 AM, Dilan Udara Ariyaratne <[email protected]> wrote: > Hi Ashen, > > Added Few more suggestions. Please go through and verify. > > Thanks, > Dilan. > > *Dilan U. Ariyaratne* > Senior Software Engineer > WSO2 Inc. <http://wso2.com/> > Mobile: +94766405580 <%2B94766405580> > lean . enterprise . middleware > > > On Thu, Aug 10, 2017 at 7:23 PM, Ashen Weerathunga <[email protected]> wrote: > >> Hi Dilan, >> >> I have done the requested changes and updated the PR. >> >> Thanks, >> Ashen >> >> On Thu, Aug 10, 2017 at 6:23 AM, Dilan Udara Ariyaratne <[email protected]> >> wrote: >> >>> Hi Ashen, >>> >>> Went through the code and added few comments, Please go through and >>> verify. >>> >>> Thanks, >>> Dilan. >>> >>> *Dilan U. Ariyaratne* >>> Senior Software Engineer >>> WSO2 Inc. <http://wso2.com/> >>> Mobile: +94766405580 <%2B94766405580> >>> lean . enterprise . middleware >>> >>> >>> On Wed, Aug 9, 2017 at 1:44 PM, Ashen Weerathunga <[email protected]> >>> wrote: >>> >>>> Hi, >>>> >>>> Can you please review and merge the PR [1]. This is regarding the Issue >>>> [2]. >>>> >>>> [1] https://github.com/wso2/carbon-kernel/pull/1464 >>>> [2] https://github.com/wso2/carbon-kernel/issues/1467 >>>> >>>> >>>> Thanks, >>>> Ashen >>>> -- >>>> *Ashen Weerathunga* >>>> Software Engineer >>>> WSO2 Inc.: http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> Email: [email protected] >>>> Mobile: +94716042995 <94716042995> >>>> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga >>>> <http://lk.linkedin.com/in/ashenweerathunga>* >>>> <http://wso2.com/signature> >>>> >>>> _______________________________________________ >>>> Dev mailing list >>>> [email protected] >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >> >> >> -- >> *Ashen Weerathunga* >> Software Engineer >> WSO2 Inc.: http://wso2.com >> lean.enterprise.middleware >> >> Email: [email protected] >> Mobile: +94716042995 <94716042995> >> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga >> <http://lk.linkedin.com/in/ashenweerathunga>* >> <http://wso2.com/signature> >> > > -- *Ashen Weerathunga* Software Engineer WSO2 Inc.: http://wso2.com lean.enterprise.middleware Email: [email protected] Mobile: +94716042995 <94716042995> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga <http://lk.linkedin.com/in/ashenweerathunga>* <http://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
