Sorry above link [1] is broken. Check [1] and [2] given below. [1] https://github.com/wso2/carbon-identity-framework/pull/1012 [2] https://github.com/wso2-extensions/identity-inbound-auth-oauth/pull/457
On Mon, Aug 28, 2017 at 3:28 PM, Nuwandi Wickramasinghe <[email protected]> wrote: > Fixed with [1] and [2] > > [1] https://github.com/wso2/carbon-identity-framework/pull/1012 > <http://www.google.com/url?q=http%3A%2F%2F10.100.7.12%3A8000%2F&sa=D&sntz=1&usg=AFQjCNGHlJg6URdHIh06U7nBzixwRGFV3w> > [2] https://github.com/wso2-extensions/identity-inbound- > auth-oauth/pull/457 > > On Mon, Aug 28, 2017 at 12:25 PM, Nuwandi Wickramasinghe < > [email protected]> wrote: > >> >> >> On Sat, Aug 26, 2017 at 12:32 PM, Johann Nallathamby <[email protected]> >> wrote: >> >>> In fix [1], we've introduced a new Util class for URI validation. We >>> already have a rich set of validations in [2]. >>> >>> Won't this help here? I think we do have URL pattern define here >>> already. If we don't have a pattern defined we need to improve this utility >>> and reuse everywhere. >>> >> Looks like we can remove the new Util class and use the validation >> utility from the identity-core. Will have to introduce new regex pattern >> for oauth callback URIs since we cannot add URI fragments in them. >> >>> >>> I already sent a previous mail on reusing JS validation utilities in UI >>> layer also [3]. >>> >>> [1] https://github.com/wso2-extensions/identity-inbound-auth-oau >>> th/commit/0db19e8602d3831d596e04c3ec68d8a35b9c840b#diff-0887 >>> 37b86ff1f8e078854ea4bf1e350eR31 >>> <https://github.com/wso2-extensions/identity-inbound-auth-oauth/commit/0db19e8602d3831d596e04c3ec68d8a35b9c840b#diff-f34cc40ce27fc26f2c28135797acb814> >>> [2] https://github.com/wso2/carbon-identity-framework/blob/m >>> aster/components/identity-core/org.wso2.carbon.identity.base >>> /src/main/java/org/wso2/carbon/identity/base/IdentityValidationUtil.java >>> [3] [IAM] Can't we do the same fix by adding fragment component as a >>> blacklisted pattern to our JS util method? >>> >>> -- >>> Thanks & Regards, >>> >>> *Johann Dilantha Nallathamby* >>> Senior Lead Solutions Engineer >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - *+94777776950* >>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>> >> >> >> >> -- >> >> Best Regards, >> >> Nuwandi Wickramasinghe >> >> Software Engineer >> >> WSO2 Inc. >> >> Web : http://wso2.com >> >> Mobile : 0719214873 >> > > > > -- > > Best Regards, > > Nuwandi Wickramasinghe > > Software Engineer > > WSO2 Inc. > > Web : http://wso2.com > > Mobile : 0719214873 > -- Best Regards, Nuwandi Wickramasinghe Software Engineer WSO2 Inc. Web : http://wso2.com Mobile : 0719214873
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
