Hi Johann, On Mon, Sep 4, 2017 at 8:18 PM Johann Nallathamby <joh...@wso2.com> wrote:
> Hi Hasanthi/Nuwandi/IAM Team, > > 1. Can we please add a description in the JIRA as to what this JIRA is for? > > 2. The fix has made a public enum change: > "MAX_ATTEMTS_EXCEEDED" -> "MAX_ATTEMTS_EXCEEDED". > Is this intentional? In any case the spelling is still wrong. > > 3. We have introduced a new protected method > "setUserClaimsValuesInUserStore". Again is this intentional? And we have a > threadlocal solution to prevent listenered being triggered twice. In that > case do we need this new method? > Here we are going to support account locking failure reason. In that case, we need a way to identify following account lock reasons separately. - Admin Lock User Account - Account not confirmed - Account locked due to exceeding max failure attempts We have to check account lock claim in setUserClaimValues method to check whether admin user is going to lock a user. Since the recursion in UserStoreBasedIdentityDaaStore, we can't put that logic inside setUserClaimValues method, because we use setUserClaimValues method to store the reason for other scenarios as well. Thanks Isura. > [1] https://wso2.org/jira/browse/IDENTITY-6324 > > Thanks & Regards, > Johann. > > -- > > *Johann Dilantha Nallathamby* > Senior Lead Solutions Engineer > WSO2, Inc. > lean.enterprise.middleware > > Mobile - *+94777776950* > Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* > -- *Isura Dilhara Karunaratne* Associate Technical Lead | WSO2 Email: is...@wso2.com Mob : +94 772 254 810 Blog : http://isurad.blogspot.com/
_______________________________________________ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
