Hi Johann, Sorry for the mistake. I have sent two separate emails for the issue.
On Thu, Oct 12, 2017 at 11:55 AM, Johann Nallathamby <[email protected]> wrote: > Hi Isuranga, > > First of all thank you for your contribution to WSO2 Identity Server. > > However, can you please follow the following protocol in order to get your > PRs merged faster. > > 1. Create one JIRA per issue. Make sure you give the description clearly. > Add the PRs related to the issue in the JIRA. > 2. Send a mail to dev with the subject indicating the issue you are fixing > (prefix with "[IAM]" is recommended). > 3. Describe the problem (can be the same as description of the JIRA). > 4. Give the references to the JIRA and PRs. > 5. Request to review and merge. > > In the above mail there is no mention of the issue neither in the subject > nor body. This won't get the attention of the required individuals (IAM) > since the dev mailing list is a global mailing list for all development > queries in WSO2. > > Also there are two separate issues in this mail. Always stick to one mail > per issue so the discussion is focussed on one issue only. You have already > sent a mail for the balana initialization issue [1]. You can add relevant > JIRA and PR to that. Please send a separate mail for the custom function > issue. > > Thanks again for the contribution. > > [1] "[Dev][IS][XACML] Introducing a Custom functionId" > > Regards, > Johann. > > On Thu, Oct 12, 2017 at 10:52 AM, Isuranga Perera < > [email protected]> wrote: > >> Can you please review and merge PR[1] and PR[2]. >> >> [1] https://github.com/wso2/balana/pull/75 >> [2] https://github.com/wso2/carbon-identity-framework/pull/1112 >> >> Best Regards >> Isuranga Perera >> > > > > -- > Thanks & Regards, > > *Johann Dilantha Nallathamby* > Senior Lead Solutions Engineer > WSO2, Inc. > lean.enterprise.middleware > > Mobile - *+94777776950* > Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
