Hi All, Since in current code when responseAction is set to discard, the state change of end point is not happening. So to rectify that I have created the following PR [1].
[1] https://github.com/wso2/wso2-synapse/pull/1008 Thanks, On Wed, Jan 10, 2018 at 10:13 AM, Isuru Udana <[email protected]> wrote: > retriesBeforeSuspension and responseAction should be two unrelated > parameters. > responseAction just there to decide what to do (should we invoke the fault > sequence or not) when request get timed-out. > > Let's not get confused with TIMEOUT state of endpoint life-cycle and the > request timeout duration of the endpoint. > > > On Wed, Jan 10, 2018 at 10:04 AM, Senduran Balasubramaniyam < > [email protected]> wrote: > >> Hi Malaka, >> >> The retriesBeforeSuspension is set and the responseAction is discard, we >> should discard the message for the number of retriesBeforeSuspension times. >> And once that cont is exceeded and the request failed we should move to >> suspension state. >> It the retriesBeforeSuspension count is not working as expected, we >> should fix that and make the document clear. >> Also as you suggested, lets have a state diagram so that it will be clear >> >> Regards >> Senduran >> >> On Tue, Jan 9, 2018 at 5:30 PM, Nandika Jayawardana <[email protected]> >> wrote: >> >>> I do not see a relationship between 'discard' action and >>> retriesBeforeSuspention count and documentation also ambiguous with respect >>> to this. >>> >>> Regards >>> Nandika >>> >>> On Tue, Jan 9, 2018 at 3:55 PM, Isuru Udana <[email protected]> wrote: >>> >>>> Hi Malaka, >>>> >>>> >>>> >>>> On Tue, Jan 9, 2018 at 3:15 PM, Malaka Gangananda <[email protected]> >>>> wrote: >>>> >>>>> Hi All, >>>>> >>>>> In EndPoint error handling scenarios when we define the >>>>> “responseAction” as “discard” the endpoint will not be get suspended >>>>> whether the “retriesBeforeSuspension” count exceeded. >>>>> >>>>> In the documentation we have mentioned that in the “Timeout” state it >>>>> will continue to attempt to receive messages until one message succeeds or >>>>> the maximum retry setting has been reached. If the maximum is reached at >>>>> which point the endpoint is marked as "Suspended." >>>>> >>>>> So when the “responseAction” is defined as “discard” is this the >>>>> expected behaviour? >>>>> >>>> Expected behaviour is to discard the timed-out message without invoking >>>> the fault sequence. >>>> >>>> Thanks. >>>> >>>>> >>>>> >>>>> Thanks, >>>>> -- >>>>> Malaka. >>>>> -- >>>>> Malaka Gangananda - Software Engineer | WSO2 >>>>> Email : [email protected] >>>>> Mobile : +94713564340 <071%20356%204340> >>>>> Web : http://wso2.com >>>>> <http://wso2.com/signature> >>>>> >>>> >>>> >>>> >>>> -- >>>> *Isuru Udana* >>>> Senior Technical Lead >>>> WSO2 Inc.; http://wso2.com >>>> email: [email protected] cell: +94 77 3791887 <077%20379%201887> >>>> blog: http://mytecheye.blogspot.com/ >>>> >>> >>> >>> >>> -- >>> Nandika Jayawardana >>> WSO2 Inc ; http://wso2.com >>> lean.enterprise.middleware >>> >> >> >> >> -- >> *Senduran * >> Senior Software Engineer, >> WSO2, Inc.; http://wso2.com/ <http://wso2.com/> >> Mobile: +94 77 952 6548 <077%20952%206548> >> > > > > -- > *Isuru Udana* > Senior Technical Lead > WSO2 Inc.; http://wso2.com > email: [email protected] cell: +94 77 3791887 <+94%2077%20379%201887> > blog: http://mytecheye.blogspot.com/ > -- Malaka. -- Malaka Gangananda - Software Engineer | WSO2 Email : [email protected] Mobile : +94713564340 Web : http://wso2.com <http://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
