Using Findbugs filters would be the right way. Having the FindBug annotations introduces another dependency to the pom as well.
Hemika Kodikara WSO2 Inc. lean . enterprise . middleware http://wso2.com Mobile : +94777688882 On Mon, Jan 22, 2018 at 2:37 PM, Lasantha Samarakoon <[email protected]> wrote: > [-Engineering, +Dev] > > AFAIK we are using Findbugs Filters[1][2] to suppress warning over > following the annotation method. > > [1] http://findbugs.sourceforge.net/manual/filter.html > [2] https://github.com/wso2/carbon-analytics-common/blob/ > master/findbugs-exclude.xml > > > *Lasantha Samarakoon* | Software Engineer > WSO2, Inc. > #20, Palm Grove, Colombo 03, Sri Lanka > Mobile: +94 (71) 214 1576 <+94%2071%20214%201576> > Email: [email protected] > Web: www.wso2.com > > lean . enterprise . middleware > > On Mon, Jan 22, 2018 at 2:08 PM, Shan Jayathilaka <[email protected]> wrote: > >> Adding engineering group, Isura, Sagara and Ruwan >> >> Shan Chathusanda Jayathilaka >> Software Engineer (Intern) >> WSO2 Inc. >> >> Mobile : +94702062877 <+94%2070%20206%202877> >> Email : [email protected] >> LinkedIn : www.linkedin.com/in/shanchathusanda/ >> >> >> On Mon, Jan 22, 2018 at 12:39 PM, Shan Jayathilaka <[email protected]> >> wrote: >> >>> Hi all, >>> >>> Currently I am developing the transaction support for the JdbcTemplate >>> which is a utility for the jdbc executions. When developing this >>> transaction support there was a warning from the findBugs mentioning that >>> "SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING" for the [1]. >>> methods which is doing the executions of the queries. I use [2]. >>> suppressWarning annotations to avoid that warning from the findBugs. Is it >>> fine to use this annotations to avoid this warning with putting annotations >>> to the top of the methods. >>> Kindly requesting your feedback. >>> >>> [1]. https://github.com/ShanChathusanda93/carbon-utils/blob/jdbc/ >>> components/org.wso2.carbon.database.utils/src/main/java/org/ >>> wso2/carbon/database/utils/jdbc/JdbcTransactionTemplate.java#L186 >>> [2]. https://github.com/ShanChathusanda93/carbon-utils/blob/ >>> jdbc/components/org.wso2.carbon.database.utils/src/main/ >>> java/org/wso2/carbon/database/utils/jdbc/JdbcTransactionTemp >>> late.java#L184 >>> >>> Best regards, >>> Shan Chathusanda Jayathilaka >>> Software Engineer (Intern) >>> WSO2 Inc. >>> >>> Mobile : +94702062877 <+94%2070%20206%202877> >>> Email : [email protected] >>> LinkedIn : www.linkedin.com/in/shanchathusanda/ >>> >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "WSO2 Engineering Group" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/a/wso2.com/d/optout. >> > > > _______________________________________________ > Dev mailing list > [email protected] > http://wso2.org/cgi-bin/mailman/listinfo/dev > >
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
