Hi Shazni, That's the issue. To determine if it's a dataservice, again we need the service data.
On Sat, Jan 27, 2018 at 10:56 PM, Shazni Nazeer <[email protected]> wrote: > Hi Tishani, > > Isn't there a way to determine if it's a dataservice at the time of > deletion. If you have a way, can't we special case the daataservice > deletion without affecting other places that need archive name. > > On Thu, Jan 25, 2018 at 12:59 AM, Thishani Lucas <[email protected]> > wrote: > >> Hi All, >> >> Earlier we had issues in the EI where we couldn't delete faulty services >> and we could delete services deployed via capps. These are reported in the >> public jiras [1] and [2] and the fixes are done respectively in [3] and >> [4]. Now we have a scenario where we shouldn't allow deletion of faulty >> services deployed via a capp. >> >> I tried to implement this by something similar to what I did in [5] >> where, before sending the service names to be deleted, we check whether the >> service is deployed via a capp. This worked perfectly fine with proxy >> services. But for data services, it's throwing an error at the place where >> service data is retrieved because for faulty data services, the service >> name is returned as the archive name (/dataservices/name.dbs). If we fix >> this, it would break the other places where the archive name is needed like >> in [6]. Because of these issues, I'm putting this implementation on hold. >> >> Please provide your concerns about this issue. >> >> [1] https://wso2.org/jira/browse/ESBJAVA-4068 >> [2] https://wso2.org/jira/browse/ESBJAVA-4139 >> [3] https://github.com/wso2/carbon-deployment/pull/286 >> [4] https://github.com/wso2/carbon-deployment/pull/285 >> [5] https://github.com/wso2/carbon-deployment/blob/4.7.x/com >> ponents/service-mgt/axis2-service-mgt/org.wso2.carbon.servic >> e.mgt.ui/src/main/resources/web/service-mgt/delete_ >> service_groups_ajaxprocessor.jsp#L89 >> [6] https://github.com/wso2/carbon-deployment/blob/4.7.x/com >> ponents/service-mgt/axis2-service-mgt/org.wso2.carbon.servic >> e.mgt/src/main/java/org/wso2/carbon/service/mgt/ServiceAdmin.java#L779 >> >> Thanks, >> Thishani >> >> -- >> Regards, >> >> *Thishani Lucas* >> *Software Engineer* >> *WSO2 Lanka (Private) Limited**: http://wso2.com <http://wso2.com/>* >> *lean.enterprise.middle-ware* >> >> *Tel: +94 77 2556931 <+94%2077%20255%206931> * >> >> *LinkedIn: https://www.linkedin.com/in/thishani-lucas/ >> <https://www.linkedin.com/in/thishani-lucas/>* >> >> <http://wso2.com/signature> >> > > > > -- > Shazni Nazeer > > Mob : +94 777737331 > LinkedIn : http://lk.linkedin.com/in/shazninazeer > > Blogs : > > https://medium.com/@mshazninazeer > http://shazninazeer.blogspot.com > > <http://wso2.com/signature> > -- Regards, *Thishani Lucas* *Software Engineer* *WSO2 Lanka (Private) Limited**: http://wso2.com <http://wso2.com/>* *lean.enterprise.middle-ware* *Tel: +94 77 2556931 * *LinkedIn: https://www.linkedin.com/in/thishani-lucas/ <https://www.linkedin.com/in/thishani-lucas/>* <http://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
