Hi Ayesha, Thanks, I will follow the steps you suggested to fix this issue for now.
thanks, On Wed, Aug 29, 2018 at 2:31 PM Ayesha Dissanayaka <[email protected]> wrote: > Hi Senthalan, > > As we are going to fix this from the backend level, let's do using error > codes. From the backend, send a proper error code and add it as the key in > resource.properties. > > However, fix need to be done in multiple places in identity-framework and > other components as there are many places sending the error messages as > Descriptions. These are not eligible to be added as keys in > resource.properties file. Need thorough testing with all the error > scenarios in IS after the changes are made. > > Alternatively, you may change the logic here to check the availability of > key without encoding first, and if not found, then do encoding. > > [1] > https://github.com/ayshsandu/carbon-identity-framework/blob/3526ccdd770e6e84bdaacbd03d99787062ea9163/components/authentication-framework/org.wso2.carbon.identity.application.authentication.endpoint.util/src/main/java/org/wso2/carbon/identity/application/authentication/endpoint/util/AuthenticationEndpointUtil.java#L155 > <https://www.google.com/url?q=https://github.com/ayshsandu/carbon-identity-framework/blob/3526ccdd770e6e84bdaacbd03d99787062ea9163/components/authentication-framework/org.wso2.carbon.identity.application.authentication.endpoint.util/src/main/java/org/wso2/carbon/identity/application/authentication/endpoint/util/AuthenticationEndpointUtil.java%23L155&sa=D&source=hangouts&ust=1535619220181000&usg=AFQjCNF2pdq5DKiwZ15vUO4Tx994ARohPA> > > Thanks! > -Ayesha > > > On Wed, Aug 29, 2018 at 7:37 AM, Senthalan Kanagalingam < > [email protected]> wrote: > >> Hi all, >> >> When we want to send the custom status and status message from backend >> referring to the keys in the resources.properties, the current >> implementation[1] encode the key from the backend and tries to find the >> encoded value from the resources.properties file. This leads to having >> encoded values in resources.properties file. >> >> bWlzY29uZmlndXJhdGlvbi5lcnJvcg__=Misconfiguration Error! >> c29tZXRoaW5nLndlbnQud3JvbmcuY29udGFjdC5hZG1pbg__=Something went wrong during >> the authentication process. Please contact identity admin. >> >> This will not user-friendly. >> >> So I have planned to change the implementation as in the back end sending >> the encoded value of the key and in the front end, we will decode the >> received key from the request and decode it and look for the decoded value >> in the resources.properties file. >> >> Will this change affect any existing implementations? >> >> [1] - https://github.com/wso2/carbon-identity-framework/pull/1306 >> >> thanks, >> Senthalan >> -- >> >> *Senthalan Kanagalingam* >> *Software Engineer - WSO2 Inc.* >> *Mobile : +94 (0) 77 18 77 466* >> <http://wso2.com/signature> >> > > > > -- > *Ayesha Dissanayaka* > Associate Technical Lead > WSO2, Inc : http://wso2.com > <http://www.google.com/url?q=http%3A%2F%2Fwso2.com&sa=D&sntz=1&usg=AFQjCNEZvyc0uMD1HhBaEGCBxs6e9fBObg> > 20, Palm grove Avenue, Colombo 3 > E-Mail: [email protected] <[email protected]> > Mobile: +94713580922 > -- *Senthalan Kanagalingam* *Software Engineer - WSO2 Inc.* *Mobile : +94 (0) 77 18 77 466* <http://wso2.com/signature>
_______________________________________________ Dev mailing list [email protected] http://wso2.org/cgi-bin/mailman/listinfo/dev
