[ 
https://issues.apache.org/jira/browse/XALANJ-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15386352#comment-15386352
 ] 

Boris commented on XALANJ-2189:
-------------------------------

We ran into the same bug. I poked a bit around, created a much smaller testcase 
and with this I found out - thanks to git bisect - that the commit that broke 
this was revision 338150 in the svn (which is commit fc90504a in the official 
git mirror).

This commit is pretty big as it included support for JAXP 1.3, but I found the 
change to Variable.java pretty interesting, because it commented a "hack" in 
the code that (according to the comment) was "needed to evaluate xpaths from 
extensions":

https://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xpath/operations/Variable.java?r1=338103&r2=338150

I guess this was removed because it was a hack and using "getVariableOrParam" 
in this case was deemed to be a better way, but this is what seems to break the 
evaluate function.

I've still got no clue what exactly is going on, but reverting this part of the 
change does fix the bug. But of course without really understanding it I don't 
know what it might break regarding the JAXP 1.3 feature. I ran the minitest and 
smoketest and they seemed fine.
I don't want to argue to go back to using the old hack without really knowing 
the consequences, but I thought at least I'd share what I found out so far. 
I'll also append the smaller testcase that I've used in case someone is 
interested.

> xalan:evaluate behavior seems to have changed in 2.7 and this change has 
> broken existing applications
> -----------------------------------------------------------------------------------------------------
>
>                 Key: XALANJ-2189
>                 URL: https://issues.apache.org/jira/browse/XALANJ-2189
>             Project: XalanJ2
>          Issue Type: Bug
>          Components: Xalan-extensions
>    Affects Versions: 2.7
>         Environment: Windows XP, JDK 1.4.2_08
>            Reporter: Rick Bullotta
>            Assignee: Ilene Seelemann
>            Priority: Critical
>         Attachments: Dataset.xml, SubtotalOutput.xml, SubtotalTransform.xsl
>
>
> See attached source XML and transform as well as what the correct result 
> should be (when used with Xalan 2.6.x).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org

Reply via email to