Thank you for your continued efforts Mukul. I'm sorry to keep putting this RC attempts down but I keep on thinking about this from a potential contributor's POV:
I don't think I can endorse this RC because it cannot be tested without editing the instructions, not to say anything of xalan-test/build.bat which is not usable at all. I suppose we got away with not testing RCs in the past in a normal way, I don't think this is acceptable anymore and we've made the first step by adding the xalan-test dir to the src zip but it is not in the xalan-java repo which is (1) confusing and (2) makes it too hard to write and use a readme that works from a xalan-test repo AND the xalan-test folder. Also, don't touch ANT_HOME. IMO there should be: - ONE repo: xalan-java. The repo xalan-test should be retired. - Validating an RC must be as 'simple' as: download the src zip, unzip it and depend on the user's preset ANT_HOME, JAVA_HOME, and JARDIR environment variables, and a README that matches. TY again for your patience and work here, Gary On 2022/12/24 13:43:48 Mukul Gandhi wrote: > Hi Gary, > > On Sat, Dec 24, 2022 at 6:23 PM Gary D. Gregory <ggreg...@apache.org> wrote: > > > Did you try to build from a src zip? > > Yes I did. And that worked fine for me. > > > As a side note, the README file is confusing because it talks about cloning > > the xalan test repo and the contents of the repo are in fact in the src zip. > > The latest README file, thats available on xalan-java repos at > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint > (and also at the location xalan-j_2_7_3-src.zip -> xalan-j_2_7_3) has > this clarification. > > The following are the relevant paragraphs mentioned within latest > README file, that clarify these points, > > The details mentioned within this file, may also be used, by XalanJ > source distribution users to build and test XalanJ from the source > distribution (except that, "git clone" steps as mentioned within this > file, shall not be required to be run by XalanJ source distribution > users). > > and, > > (2) Steps to run the XalanJ tests, on XalanJ implementation > > 1) Go to the XalanJ tests repos's, local git clone folder: > cd ..\xalan-test > > For XalanJ source distribution users, xalan-test folder, is located at > the root of the XalanJ source distribution folder (i.e, parallel to > folders "src", "tools" etc) from where XalanJ > source distribution users may run XalanJ tests. > > > - Download and unzip > > https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC7/xalan-j_2_7_3-src.zip > > - cd xalan-j_2_7_3 > > - build clean fulldist > > - cd xalan-test > > - build clean jar FAILS with: > > > > build beginning... > > Error: Could not find or load main class org.apache.tools.ant.Main > > build completed! > > > Running "build clean jar" fails and ANT_HOME has been updated to > > "..\xalan-java" > > Within the folder xalan-test, of the src distribution, > > We need to replace set ANT_HOME=..\xalan-java (that's there, for > users of the XalanJ repos) > > with set ANT_HOME=.. > > and then xalan-test build from src distribution shall find ant > run-time and shall work. > > It's also advisable to set environment variable JARDIR and store jar > files within it, as mentioned within the XalanJ README file. > > Please let us know, whether above mentioned clarifications work fine. > > > -- > Regards, > Mukul Gandhi > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org > For additional commands, e-mail: dev-h...@xalan.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
