Thank you Mukul for this RC. +1
- Reviewing src zip: ASC, SHA files OK. - Building runtime with 'chmod +x ./build.sh && ./build.sh clean fulldist' OK. - Following the README, there is confusion because the unzipped src zip creates a `xalan-test` folder as a child folder but the README describes it as a sibling folder. Does this skew the tests or cause issues? - TODOs later: -- Fix Javadoc errors -- Test output should be quieter in non-debug mode: No need to tell me all the test files that PASS, I have no idea if I am missing any failure output without tediously reviewing ALL console output. Using: ant -version Apache Ant(TM) version 1.10.13 compiled on January 4 2023 java -version openjdk version "1.8.0_362" OpenJDK Runtime Environment (build 1.8.0_362-bre_2023_01_22_03_32-b00) OpenJDK 64-Bit Server VM (build 25.362-b00, mixed mode) uname -a Darwin *** 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:42:11 PST 2023; root:xnu-8792.81.3~2/RELEASE_X86_64 x86_64 Gary On Sat, Mar 25, 2023 at 11:32 AM Mukul Gandhi <muk...@apache.org> wrote: > Hi all, > I've published the new RC for XalanJ 2.7.3 release (located at > https://dist.apache.org/repos/dist/dev/xalan/j/2.7.3/RC10/). This RC, > uses Apache Commons BCEL 6.7.0, and also provides means to build and > test XalanJ from the source distribution. > > Since the previous XalanJ RC, this RC provides following improvements, > 1) Few improvements to the XalanJ implementation and tests build > scripts, based on feedback from XalanJ list members. > 2) New linux build scripts, for XalanJ implementation and tests builds. > 3) Implementation of few new XalanJ tests, for the jira issues solved > for XalanJ 2.7.3. > 4) Upgrade to the latest jtidy library (that parses XalanJ tests > output HTML documents). > 5) Suppression of few error messages, during XalanJ tests build, whose > context was not clear. > > The apache git tags corresponding to this RC, are following (these > have been committed as well), > xalan-java repos (branch xalan-j_2_7_1_maint) : xalan-j_2_7_3-rc10 > xalan-test repos (branch master) : xalan-j_2_7_3-rc10 > > I've verified the working of this RC, both on windows and linux > platforms, and necessary build tests pass as discussed during review > of XalanJ RC9. > > The key that can be used, to verify this RC is located within the > file, at https://dlcdn.apache.org/xalan/xalan-j/KEYS. > > The XalanJ readme file, has been updated here > > https://gitbox.apache.org/repos/asf?p=xalan-java.git;a=blob_plain;f=README;hb=refs/heads/xalan-j_2_7_1_maint > , > describing the XalanJ build and tests process. > > Kindly review and vote, for this XalanJ 2.7.3 RC. > > Great work everyone. Here's my +1 for this RC. > > > -- > Regards, > Mukul Gandhi >
