elharo commented on PR #1: URL: https://github.com/apache/xalan-test/pull/1#issuecomment-1540802716
My thinking is this. Is there currently an equivalent of `mvn test` for this repo? E.g. ant test or ./build.sh test or something like that? And if so does that currently pass? If the tests for this repo are currently passing (after whatever other config and setup steps are required) then I'd prefer not to merge PRs that break them. If, OTOH, this doesn't even build yet and this moves us closer to making it build and tests pass, then we might as go ahead and merge. I'm not familiar with somewhat idiosyncratic Xalan build, so I'm not sure which case is true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
